Fix wandb integration issues in MetricsLogger #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add check to prevent re-initializing wandb if already active - Implement global step tracking to ensure monotonic step numbers - Only finish wandb runs if they were started by MetricsLogger - Fixes issues with user-managed wandb sessions and step counting warnings
|
It would be great if these changes could be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes wandb integration issues in MetricsLogger reported in #137:
Prevents wandb re-initialization: Added check to ensure MetricsLogger doesn't initialize wandb if a run is already active, fixing "You must call wandb.init() before wandb.log()" error when users manually initialize wandb.
Ensures monotonic step tracking: Implemented global step counter
_last_stepsthat tracks steps per metric prefix, preventing "Tried to log to step 0 that is less than the current step 3" warnings.Conditional wandb.finish(): Only finishes wandb runs if they were started by MetricsLogger, avoiding interference with user-managed sessions.
Reference
Checklist