Skip to content

Conversation

@BenRKarl
Copy link
Contributor

@BenRKarl BenRKarl commented Dec 1, 2025

Removing this file allows the Ads library to successfully generate when using NextGen protos. When present, the code gen process fails with a Sig 9 error.

@BenRKarl BenRKarl requested a review from a team as a code owner December 1, 2025 16:22
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 1, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @BenRKarl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue preventing the successful generation of the Ads library. By removing a problematic template file, the code generation process, particularly when utilizing NextGen protos, can now complete without encountering a Sig 9 error, thereby unblocking development and ensuring proper library functionality.

Highlights

  • Fix Code Generation: Removed a specific template file that was causing a Sig 9 error during the Ads library code generation process when using NextGen protos.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Jinja2 template responsible for generating the top-level __init__.py file that provides a flattened view of the client library. The stated reason is to fix a code generation failure (SIGKILL error) for the large Google Ads library. While removing this file will solve the immediate issue, it's a global change that will affect all libraries generated by this tool, removing the convenience of flattened imports. My review suggests making the generation of this file conditional based on a generator option, which would offer a more flexible solution instead of removing it entirely.

@BenRKarl BenRKarl changed the base branch from next-gen-prototype-2024-11-14 to main December 5, 2025 19:03
@BenRKarl BenRKarl changed the title Delete file that prevents Ads library from generating Changes to generate NextGen protos in Ads library Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants