Merged
Conversation
dazuma
force-pushed
the
pr/rails8
branch
2 times, most recently
from
7ecc093 to
cb299e0
Compare
dazuma
force-pushed
the
pr/rails8
branch
3 times, most recently
from
7a462e3 to
a526d7c
Compare
Member
|
commit message: Also the helpers are now preloaded differently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test of updating Rails from 5.2 to 8.0. It has a prerequisite of updating Ruby to at least 3.2. (Currently the Bazel configs include Ruby 3.1.3.)
The change is only in how templates are named. They must be suffixed with ".text.erb" instead of ".erb" to ensure they are handled as plain text and no html escaping is done. Also, they are invoked with no suffixes on their name.