Open
Conversation
This reverts commit bea42b2. # Conflicts: # handwritten/bigquery/src/bigquery.ts # handwritten/bigquery/src/job.ts # handwritten/bigquery/test/bigquery.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts high precision timestamp changes that allow users to read timestamps with high precision values that are stored on the backend. The service doesn't provide high precision timestamp support in GA yet which caused us to pin the release due to the issue at #7286. But new features for Bigquery need to be rolled out so this PR reverts the commits that caused the issue which allow us to release newer versions of Bigquery.
Reverts:
#7147
googleapis/nodejs-bigquery#1596
Impact
This unblocks releases for Node Bigquery.
Testing
Testing for high precision timestamps has been removed because the functionality has been removed. All integration tests pass for a non-allowlisted project.