fix(gax): abort stalled REST fallback fetches#7949
Open
akshatbaranwal wants to merge 1 commit intogoogleapis:mainfrom
Open
fix(gax): abort stalled REST fallback fetches#7949akshatbaranwal wants to merge 1 commit intogoogleapis:mainfrom
akshatbaranwal wants to merge 1 commit intogoogleapis:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deadlineto an actual abort timer for REST fallback fetchescancel()abort the underlying fetch instead of only the parser-owned controllerWhy
In REST fallback mode, server-streaming reads can silently stall after fetch dispatch but before the first response byte. Before this change:
cancel()aborted the parser-owned controller, not the fetch-owned controllerThat combination leaves stalled REST fallback fetches effectively unbounded and uncancellable.
Testing
cd core/packages/gax && npm run compilecd core/packages/gax && npx mocha build/test/unit/grpc-fallback.js