chore: librarian update image pull request: 20260205T214646Z#15532
Merged
chore: librarian update image pull request: 20260205T214646Z#15532
Conversation
…prod/images-prod/python-librarian-generator@sha256:f5426423676c75008c2135037e7b98f78cbb99f78b3c46fe043b6897be92d836
Contributor
Author
|
One or more libraries have failed to generate, please review PR description for a list of failed libraries. |
Contributor
Summary of ChangesHello @ohmayr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine update of the Python librarian generator image. Alongside this, it introduces a widespread refactoring of protobuf import statements to a more explicit Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request appears to be an automated update from the librarian tool, refreshing the generator image and regenerating client libraries. The changes are mostly stylistic, such as updating import formats and serialization methods, which is fine. The identified recurring issue across many of the generated rest.py transport files regarding the use of bare except: clauses remains, as it is a valid concern not covered by the provided rules. All comments highlighting this issue have been retained with their original suggestions. This might be an issue in the generator itself that needs to be addressed.
Comment on lines
+662
to
663
| request_payload = type(request).to_json(request) | ||
| except: |
Contributor
There was a problem hiding this comment.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
Suggested change
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
Comment on lines
+495
to
496
| request_payload = type(request).to_json(request) | ||
| except: |
Contributor
There was a problem hiding this comment.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
Suggested change
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
Comment on lines
+656
to
657
| request_payload = type(request).to_json(request) | ||
| except: |
Contributor
There was a problem hiding this comment.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
Suggested change
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
Comment on lines
+1263
to
1264
| request_payload = type(request).to_json(request) | ||
| except: |
Contributor
There was a problem hiding this comment.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
Suggested change
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
Comment on lines
+854
to
855
| request_payload = type(request).to_json(request) | ||
| except: |
Contributor
There was a problem hiding this comment.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
Suggested change
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
Comment on lines
+1287
to
1288
| request_payload = type(request).to_json(request) | ||
| except: |
Contributor
There was a problem hiding this comment.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
Suggested change
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
Comment on lines
+1444
to
1445
| request_payload = type(request).to_json(request) | ||
| except: |
Contributor
There was a problem hiding this comment.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
Suggested change
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
Comment on lines
+581
to
582
| request_payload = type(request).to_json(request) | ||
| except: |
Contributor
There was a problem hiding this comment.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
Suggested change
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
Comment on lines
+1128
to
1129
| request_payload = type(request).to_json(request) | ||
| except: |
Contributor
There was a problem hiding this comment.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
Suggested change
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
Comment on lines
+1242
to
1243
| request_payload = type(request).to_json(request) | ||
| except: |
Contributor
There was a problem hiding this comment.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
Suggested change
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
parthea
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:f5426423676c75008c2135037e7b98f78cbb99f78b3c46fe043b6897be92d836
Generation failed for