Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -865,6 +865,12 @@ Libraries
-
-
- `Client Library Issues <https://github.com/googleapis/google-cloud-python/issues>`_
* - `API Registry API <https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-apiregistry>`_
- preview
- |PyPI-google-cloud-apiregistry|
- `API Issues <https://issuetracker.google.com/issues?q=componentid:1979613>`_
- `File an API Issue <https://issuetracker.google.com/issues/new?component=1979613&template=2231768>`_
- `Client Library Issues <https://github.com/googleapis/google-cloud-python/issues>`_
Comment on lines +868 to +873
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new entry for API Registry API is not in the correct alphabetical position. It is placed before Access Context Manager, but it should come after it to maintain the alphabetical sorting of the library list.

References
  1. Lists, such as this list of libraries, should be kept in alphabetical order to improve readability and maintainability. This is analogous to the general rule about programmatically sorting dictionary keys.

* - `Access Context Manager <https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-access-context-manager>`_
- preview
- |PyPI-google-cloud-access-context-manager|
Expand Down Expand Up @@ -961,6 +967,18 @@ Libraries
-
-
- `Client Library Issues <https://github.com/googleapis/google-cloud-python/issues>`_
* - `Audit Manager API <https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-auditmanager>`_
- preview
- |PyPI-google-cloud-auditmanager|
- `API Issues <https://issuetracker.google.com/issues?q=componentid:1335397>`_
- `File an API Issue <https://issuetracker.google.com/issues/new?component=1335397&template=0>`_
- `Client Library Issues <https://github.com/googleapis/google-cloud-python/issues>`_
* - `Auth httplib2 <https://github.com/googleapis/google-cloud-python/tree/main/packages/google-auth-httplib2>`_
- preview
- |PyPI-google-auth-httplib2|
-
-
- `Client Library Issues <https://github.com/googleapis/google-cloud-python/issues>`_
* - `Backup and DR Service API <https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-backupdr>`_
- preview
- |PyPI-google-cloud-backupdr|
Expand Down Expand Up @@ -1465,6 +1483,12 @@ Libraries
-
-
- `Client Library Issues <https://github.com/googleapis/google-cloud-python/issues>`_
* - `Python Test Utils for Cloud <https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-testutils>`_
- preview
- |PyPI-google-cloud-testutils|
-
-
- `Client Library Issues <https://github.com/googleapis/google-cloud-python/issues>`_
* - `Quotas API <https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-quotas>`_
- preview
- |PyPI-google-cloud-quotas|
Expand Down Expand Up @@ -1874,6 +1898,8 @@ Libraries
:target: https://pypi.org/project/google-cloud-apihub
.. |PyPI-google-cloud-api-keys| image:: https://img.shields.io/pypi/v/google-cloud-api-keys.svg
:target: https://pypi.org/project/google-cloud-api-keys
.. |PyPI-google-cloud-apiregistry| image:: https://img.shields.io/pypi/v/google-cloud-apiregistry.svg
:target: https://pypi.org/project/google-cloud-apiregistry
Comment on lines +1901 to +1902
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This new badge definition for PyPI-google-cloud-apiregistry is not in the correct global alphabetical position. For instance, it's placed before PyPI-google-cloud-access-context-manager, which should appear much earlier in the list. To improve maintainability, please place new entries in their correct alphabetical position.

References
  1. Lists, such as this list of badge definitions, should be kept in alphabetical order to improve readability and maintainability. This is analogous to the general rule about programmatically sorting dictionary keys.

.. |PyPI-google-cloud-access-context-manager| image:: https://img.shields.io/pypi/v/google-cloud-access-context-manager.svg
:target: https://pypi.org/project/google-cloud-access-context-manager
.. |PyPI-google-ads-admanager| image:: https://img.shields.io/pypi/v/google-ads-admanager.svg
Expand Down Expand Up @@ -1906,6 +1932,10 @@ Libraries
:target: https://pypi.org/project/google-area120-tables
.. |PyPI-google-cloud-audit-log| image:: https://img.shields.io/pypi/v/google-cloud-audit-log.svg
:target: https://pypi.org/project/google-cloud-audit-log
.. |PyPI-google-cloud-auditmanager| image:: https://img.shields.io/pypi/v/google-cloud-auditmanager.svg
:target: https://pypi.org/project/google-cloud-auditmanager
.. |PyPI-google-auth-httplib2| image:: https://img.shields.io/pypi/v/google-auth-httplib2.svg
:target: https://pypi.org/project/google-auth-httplib2
.. |PyPI-google-cloud-backupdr| image:: https://img.shields.io/pypi/v/google-cloud-backupdr.svg
:target: https://pypi.org/project/google-cloud-backupdr
.. |PyPI-google-cloud-gke-backup| image:: https://img.shields.io/pypi/v/google-cloud-gke-backup.svg
Expand Down Expand Up @@ -2074,6 +2104,8 @@ Libraries
:target: https://pypi.org/project/google-cloud-privilegedaccessmanager
.. |PyPI-google-cloud-security-publicca| image:: https://img.shields.io/pypi/v/google-cloud-security-publicca.svg
:target: https://pypi.org/project/google-cloud-security-publicca
.. |PyPI-google-cloud-testutils| image:: https://img.shields.io/pypi/v/google-cloud-testutils.svg
:target: https://pypi.org/project/google-cloud-testutils
Comment on lines +2107 to +2108
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This new badge definition for PyPI-google-cloud-testutils is not in the correct alphabetical position. It is placed before PyPI-google-cloud-quotas, but should come after it. For better maintainability, this list of definitions should be kept in alphabetical order.

References
  1. Lists, such as this list of badge definitions, should be kept in alphabetical order to improve readability and maintainability. This is analogous to the general rule about programmatically sorting dictionary keys.

.. |PyPI-google-cloud-quotas| image:: https://img.shields.io/pypi/v/google-cloud-quotas.svg
:target: https://pypi.org/project/google-cloud-quotas
.. |PyPI-google-cloud-rapidmigrationassessment| image:: https://img.shields.io/pypi/v/google-cloud-rapidmigrationassessment.svg
Expand Down
Loading