chore: make grafeas post processing script robust

[ohmayr]

Make the grafeas client post processing script more robust.

[gemini-code-assist]

Summary of Changes

Hello @ohmayr, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the Grafeas client's generation process by making its post-processing script more robust. It achieves this by updating regex patterns to precisely remove specific, likely deprecated or centralized, client configuration and mTLS-related code from the generated Python client libraries. This cleanup also includes the removal of associated unit tests, resulting in a leaner and more maintainable codebase.

Highlights

• Enhanced Post-Processing Script: The unique-grafeas-client.yaml script was updated with more flexible and robust regular expressions to accurately identify and remove specific code blocks from the generated Grafeas client files.
• Streamlined Client Configuration: Significant portions of client configuration logic, including default endpoint definitions, mTLS handling, environment variable parsing, and service account file instantiation, were removed from both synchronous (client.py) and asynchronous (async_client.py) Grafeas clients.
• Simplified Asynchronous Client Initialization: The GrafeasAsyncClient's __init__ method was refactored to delegate its core initialization to the synchronous GrafeasClient, reducing code duplication.
• Removed Redundant Unit Tests: Corresponding unit tests for the removed client configuration and mTLS logic were deleted from test_grafeas.py, ensuring test suite consistency.

Changelog

• .librarian/generator-input/client-post-processing/unique-grafeas-client.yaml
  • Updated regex patterns to improve robustness in matching and removing code blocks.
• packages/grafeas/grafeas/grafeas_v1/services/grafeas/async_client.py
  • Simplified the __init__ method and removed api_endpoint and universe_domain properties.
• packages/grafeas/grafeas/grafeas_v1/services/grafeas/client.py
  • Removed deprecated endpoint, mTLS, and service account file handling methods and properties.
• packages/grafeas/tests/unit/gapic/grafeas_v1/test_grafeas.py
  • Removed multiple unit tests that covered client configuration, API key credentials, and mTLS endpoint resolution.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to make the grafeas client post-processing script more robust by replacing literal string matches with regular expressions. While most of the changes achieve this goal effectively, one of the new regular expressions is too broad and unanchored, which could make the script more fragile. I've added a comment with a suggestion to improve its robustness.

[gemini-code-assist]

This regular expression is too broad and not well-anchored. The [\s\S]*? will start matching right after the credentials argument in the __init__ method's signature, swallowing the rest of the signature and the docstring. This makes the match fragile and could lead to incorrect replacements if the code being modified changes.

To make this more robust, you should anchor the regex to more specific parts of the code. For example, you could match the full method signature up to ) -> None: literally, and then use a regex for the method body. A more robust before block would look something like this:

...
      \        client_info: gapic_v1.client_info.ClientInfo = DEFAULT_CLIENT_INFO,
      \    \) -> None:
      [\s\S]*?"credentialsType": None,
      \s+\},
      \s+\

This would ensure that the entire signature is matched literally before the regex part for the body begins.