Merged
Conversation
chalmerlowe
commented
Oct 23, 2025
chalmerlowe
commented
Oct 23, 2025
chalmerlowe
commented
Oct 23, 2025
chalmerlowe
commented
Oct 23, 2025
chalmerlowe
commented
Oct 23, 2025
chalmerlowe
commented
Oct 23, 2025
…python-dns into feat/add-python-3.13
…python-dns into feat/add-python-3.13
…python-dns into feat/add-python-3.13
gkevinzheng
reviewed
Oct 23, 2025
|
|
||
| env_vars: { | ||
| key: "NOX_SESSION" | ||
| value: "system blacken format" |
There was a problem hiding this comment.
Shouldn't this also have all the unit-<version> from 3.9 to 3.13?
Contributor
Author
There was a problem hiding this comment.
We are running unit tests in github actions so we do not need to duplicate those tests here in the kokoro session.
Our multi-python docker image does not have python 3.8 and 3.7 wheels due to an issue. We are able to run those unit tests under 3.7 and 3.8 in GitHub (as well as all the others up to 3.14) until we finally ditch 3.7 and 3.8 completely from all the split repos.
owlbot.py
Outdated
Comment on lines
61
to
73
| s.replace( | ||
| "noxfile.py", | ||
| 'DEFAULT_PYTHON_VERSION = "3.8"', | ||
| 'DEFAULT_PYTHON_VERSION = "3.10"' | ||
| ) | ||
|
|
||
| s.replace( | ||
| "noxfile.py", | ||
| r'SYSTEM_TEST_PYTHON_VERSIONS: List\[str\] = \["3.8"\]', | ||
| 'SYSTEM_TEST_PYTHON_VERSIONS: List[str] = ["3.10"]' | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
This can all be done with the following additional parameters in the common.py_library call:
default_python_version="3.10",
system_test_python_versions=["3.10"],
gkevinzheng
approved these changes
Oct 23, 2025
parthea
added a commit
that referenced
this pull request
Nov 12, 2025
🤖 I have created a release *beep* *boop* --- ## [0.36.0](v0.35.1...v0.36.0) (2025-11-05) ### Features * Add support for Python 3.14 ([#321](#321)) ([99c0adb](99c0adb)) * Adds Python 3.13 support ([#319](#319)) ([ea851ce](ea851ce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 24, 2025
🤖 I have created a release *beep* *boop* --- ## [0.36.0](googleapis/python-dns@v0.35.1...v0.36.0) (2025-11-05) ### Features * Add support for Python 3.14 ([#321](googleapis/python-dns#321)) ([99c0adb](googleapis/python-dns@99c0adb)) * Adds Python 3.13 support ([#319](googleapis/python-dns#319)) ([ea851ce](googleapis/python-dns@ea851ce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for Python 3.13 and makes several updates to the CI and testing configuration:
Python 3.13 Support:
CI/Testing Updates:
.github/workflows/lint.ymlfrom 3.8 to 3.10 to mirror other defaults in the nox sessions for system tests, etc.NOX_SESSIONenvironment variable in.kokoro/presubmit/presubmit.cfgto "system blacken format" to control which nox sessions run during presubmitDEFAULT_PYTHON_VERSIONin noxfile.py from 3.8 to 3.10.SYSTEM_TEST_PYTHON_VERSIONSin noxfile.py from 3.8 to 3.10.Owlbot Configuration:
s.replacecalls inowlbot.pyto persist the changes inlint.yml,presubmit.cfg, andnoxfile.pyafter owlbot post-processing. This ensures that the CI environment and test configurations use Python 3.10 by default and that the presubmit runs a specific set of nox sessions.These changes ensure that Python 3.13 is supported and that the CI environment defaults to Python 3.10 for system tests and linting, working around known issues with older Python versions (3.7 and 3.8) in the Kokoro Docker python-multi image.