Fix: Correct pydantic version range (bytes fields are broken with pydantic<=2.8). #1589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
copybara/825264775
branch
from
5a61706 to
85ce574
Compare
copybara-service
bot
changed the title
…antic<=2.8). The ser_json_bytes, val_json_bytes we rely on isn't introduced till 2.9. In old versions B64 encoded bytes fields are getting ascii decoded. - Users will see different formats of bytes depending on pydantic version. - The api fails when you send back badly coded bytes (inline_blob, thought_signature). It's possible to fix it to mostly work with older versions, but definitely not trivial to get **identical** behavior. PiperOrigin-RevId: 825591037
copybara-service
bot
force-pushed
the
copybara/825264775
branch
from
85ce574 to
d24cb56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Correct pydantic version range (bytes fields are broken with pydantic<=2.8).
The ser_json_bytes, val_json_bytes we rely on isn't introduced till 2.9.
In old versions B64 encoded bytes fields are getting ascii decoded.
It's possible to fix it to mostly work with older versions, but definitely not trivial to get identical behavior.