Conversation
codyoss
reviewed
Mar 2, 2026
codyoss
reviewed
Mar 2, 2026
Add check=True to subprocess calls for better error handling.
codyoss
requested changes
Mar 2, 2026
codyoss
approved these changes
Mar 3, 2026
codyoss
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python, os.system() executes a command in a subshell. While the command itself (like python3 owlbot.py) returns a non-zero exit code when it crashes, os.system() simply returns that value to the caller and continues execution of the script.
Because the main script (Step #5 in your logs) finished its loop without explicitly checking the return value of system() and calling sys.exit(1), Cloud Build marked Step #5 as "Finished" successfully.
other thing in this PR is adding a build script for dev purposes, you can run build.sh and test locally more easily