Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated release, bumping the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
a4f50db to
d9f7450
Compare
There was a problem hiding this comment.
Code Review
This pull request is an automated release for version 0.2.0, introducing new workflow helpers, agent personas, and recipes. While the version bumps in Cargo.toml, package.json, and Cargo.lock, along with CHANGELOG.md updates, are appropriate for a minor release, a critical security concern has been identified. The new workflow helpers are vulnerable to URL manipulation and Server-Side Request Forgery (SSRF) due to improper encoding or validation of user-supplied identifiers (e.g., calendar IDs, message IDs, file IDs) when interpolating them into API URLs. This poses a significant risk, especially as these helpers will process untrusted input from AI agents. I recommend using a robust URL encoding library or the url crate for programmatic URL construction. Additionally, I've provided a specific comment on improving the robustness of the new workflow helpers.
d9f7450 to
4c9799a
Compare
4c9799a to
90e2e76
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@googleworkspace/cli@0.2.0
Minor Changes
b0d0b95: Add workflow helpers, personas, and 50 consumer-focused recipes
gws workflowsubcommand with 5 built-in helpers:+standup-report,+meeting-prep,+email-to-task,+weekly-digest,+file-announcedocs/skills.mdskills index andregistry/recipes.yamlwith 50 multi-step recipes for Gmail, Drive, Docs, Calendar, and SheetsPatch Changes
90adcb4: fix: percent-encode path parameters to prevent path traversal
e71ce29: Fix Gemini extension installation issue by removing redundant authentication settings and update the documentation.
90adcb4: fix: harden input validation for AI/LLM callers
src/validate.rswithvalidate_safe_output_dir,validate_msg_format, andvalidate_safe_dir_pathhelpers--output-diragainst path traversal ingmail +watchandevents +subscribe--msg-formatagainst allowlist (full, metadata, minimal, raw) ingmail +watch--diragainst path traversal inscript +pushvalue_parserconstraint for--msg-formatAGENTS.md90adcb4: Security: Harden validate_resource_name and fix Gmail watch path traversal
90adcb4: Replace manual
urlencoded()with reqwest.query()builder for safer URL encodingc11d3c4: Added test coverage for
EncryptedTokenStorage::newinitialization.7664357: Add test for missing error path in load_client_config
90adcb4: fix: add shared URL safety helpers for path params (
encode_path_segment,validate_resource_name)90adcb4: fix: warn on stderr when API calls fail silently