Draft
Conversation
jsenning
requested changes
Jul 18, 2025
Member
jsenning
left a comment
There was a problem hiding this comment.
Great Start!
I think we want to also give office administrators the ability to update mail stops and office hours.
I also noticed that this route returns the users profile - including information that probably should not be sent. The UI should be examined to see if that data is used and, if not, then the UpdateOfficeLocationAsync() function should be modified to return a status rather than a profile. An alternative is to make a separate route for use by office administrators that doesn't return profile information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give members of the 360-OfficeAdmin-SG security group the ability to update faculty/staff office locations from their public profiles.
Paired with UI gordon-cs/gordon-360-ui#2753