Conversation
bennettforkner
requested changes
Jun 2, 2023
Comment on lines
+8
to
+12
| /// 2000 is a clean turn of the millennium: | ||
| /// this datetime falls under: | ||
| /// min javascript datetime (1/1/1970) | ||
| /// min sql datetime (1/1/1753) | ||
| /// min c# datetime (1/1/0001) |
Contributor
There was a problem hiding this comment.
Why add another date to the existing confusion that you reference? I would choose one of the existing ones and stick with that so that you don't make the problem worse :)
Comment on lines
+10
to
+11
| public TimeOnly? StartDate { get; set; } | ||
| public TimeOnly? EndDate { get; set; } |
Contributor
There was a problem hiding this comment.
Okay so these are timeonly types now but their names are "*Date"? Can you rename the columns/properties pls?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change upload and patch of seriesschedule to TimeOnly