Fix race condition when unmounting modal while opening it #963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a Bottom Sheet is animating in, its currentIndexRef is
-1, and is not set to0until the animation finishes. This means that if the component is unmounted while it's still opening, the modal sticks around on screen and is uncloseable. This results in a zombie bottom sheet modal that can never be removed! 🧟To replicate:
Changes:
animatingRefwhich tracks the status of the component's entry animation.animatingRefwhen minimizing the modalanimatingRefis initialized as falseanimateOnMountis set to false!onAnimateto setanimatingRef = truewhen animating