assert: look for the right function call in the source#210
Open
dnephin wants to merge 5 commits intogotestyourself:mainfrom
Open
assert: look for the right function call in the source#210dnephin wants to merge 5 commits intogotestyourself:mainfrom
dnephin wants to merge 5 commits intogotestyourself:mainfrom
Conversation
So package functions are called with the package selector. For the upcoming internal/source change to handle multiple functions on a single line.
And change the test for multiple function calls per line, now that the lookup works
So that multiple function calls on the same line do not confuse the source lookup
dnephin
force-pushed
the
multiple-call-expr-per-line
branch
from
e86e93a to
e12af39
Compare
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #195
Required moving all the tests which used
internal/sourceto external test packages.When scanning for an
ast.CallExpronly consider those that use aast.SelectorExprwhere the name of theXis a gotest.tools package. That way if there are other function calls on the line, it will continue looking for the right call.This makes the lookup logic more complicated, and will break if someone assigns
assert.<func>to a local var. Hopefully that is not a common practice.