skip: deprecate skip.If and replace it with assert.SkipIf#232
Open
dnephin wants to merge 1 commit intogotestyourself:mainfrom
Open
skip: deprecate skip.If and replace it with assert.SkipIf#232dnephin wants to merge 1 commit intogotestyourself:mainfrom
dnephin wants to merge 1 commit intogotestyourself:mainfrom
Conversation
6005812 to
bb5ff78
Compare
Instead of a very small page it should be fine to move this one exported function to the assert package.
bb5ff78 to
d2fbfd7
Compare
Member
Author
|
@vdemeester what do you think? Any concerns with removing the |
vdemeester
approved these changes
Apr 20, 2022
Member
vdemeester
left a comment
There was a problem hiding this comment.
I like reading skip.If (probably better than I would assert.SkipIf) but other than that, no real concern for deprecating skip 🙃 (on super nit is that if a user only used the skip package, now he will have go-cmp as a dependency that he didn't have before.. but it's really a nit)
Member
Author
|
Fair point! My guess is that no one would really use the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally we thought there might be more stuff to include in the
skippackage. It has been a few years, and we haven't added anything.This PR deprecates the
skippackage, and moves the one function toassert.SkipIf. Instead of a very small page it should be fine to move this one exported function to the assert package.Also improves the godoc a bit, and documents
msgAndArgsonassert.Assertas well.