This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Add .lagoon.env environment files. #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
steveworley
commented
Jul 31, 2019
steveworley
commented
- Adds a default .lagoon.env file to apply shield settings to Lagoon environments
- Adds a .lagoon.env.production to disable shield in Lagoon.
- Adds a default .lagoon.env file to apply shield settings to Lagoon environments - Adds a .lagoon.env.production to disable shield in Lagoon.
- Lagoon ineheritance defines `.lagoon.env.{$BRANCHNAME}` this would indicate that it will try and load .lagoon.env.master as this is our production branch.
|
I'm concerned that using a published default user and pass (even as a fallback) might inadvertently leave some sites exposed - it'd be better to tie it to something more obscure, but still easily discoverable to trusted users. Maybe not setting a fallback, and instead relying on the setting coming in during provisioning? |
Collaborator
|
Can we also add docs that indicate what expected behaviour is (and how to determine user/pass). I agree we shouldn't use published defaults, Ansible playbook should replace with something semi-random during provisioning? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.