Open
Conversation
Collaborator
|
CI failures look real: like ci isn't seeing the db config maybe? I'll test locally on Monday. |
* use our hostnames * Modified files from CI --------- Co-authored-by: rsalmond <4367945+rsalmond@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes our config loading logic to fetch files from
/configinstead of a path relative to the source code.We need this because the way kubernetes injects config files completely hides all the files in the target directory. Which is to say, if we inject our config files to
/app, we hide all our source code and assets.By fetching config from a separate root dir, we don't have this problem.
It seems to still work okay with the local dev experience as well, but would love to get a confirmation.