Closed
Conversation
added 27 commits
July 31, 2025 08:06
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+729
to
+744
| f""" | ||
| [!] STATUS_LOGON_FAILURE - {e} You used: | ||
| - UPN {UPN}, | ||
| - password {password}, | ||
| - target {target}, | ||
| - guest {guest}, | ||
| - kerberos {kerberos}, | ||
| - kerberos_required {kerberos_required}, | ||
| - HashNt {HashNt}, | ||
| - HashAes128Sha96 {HashAes128Sha96}, | ||
| - HashAes256Sha96 {HashAes256Sha96}, | ||
| - ST {ST}, | ||
| - KEY {KEY} | ||
|
|
||
| [💡 TIPS] If you want to use a local account you may use something like: UPN = "WORKGROUP\\\\Administrator" or UPN = "Administrator@WORKGROUP" or "Administrator@192.168.1.2" | ||
| """ |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Author
There was a problem hiding this comment.
Hm, it feels to me that it helps with the debugging to make sure that the program understood properly what you passed as an argument. Moreover, you typed those secrets in your terminal, so they will likely end-up in your bash history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at adding two capabilities to scapy-red:
I guess the code may end-up split into different projects or directories (scapy, utils, etc.). Yet, as I did not feel legitimate to propose a global project architecture, I leave it to you and wait for your suggestions.