-
Couldn't load subscription status.
- Fork 79
Run native tests without running tests on JVM first #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Run native tests without running tests on JVM first #765
Conversation
...gradle-plugin/src/main/java/org/graalvm/buildtools/gradle/dsl/NativeImageCompileOptions.java
Outdated
Show resolved
Hide resolved
...le-plugin/src/main/java/org/graalvm/buildtools/gradle/internal/DelegatingCompileOptions.java
Outdated
Show resolved
Hide resolved
native-gradle-plugin/src/main/java/org/graalvm/buildtools/gradle/NativeImagePlugin.java
Outdated
Show resolved
Hide resolved
native-gradle-plugin/src/main/java/org/graalvm/buildtools/gradle/NativeImagePlugin.java
Outdated
Show resolved
Hide resolved
native-gradle-plugin/src/main/java/org/graalvm/buildtools/gradle/NativeImagePlugin.java
Outdated
Show resolved
Hide resolved
8dfa083 to
05b4dbd
Compare
05b4dbd to
23494be
Compare
|
|
||
| public abstract class AgentUtils { | ||
|
|
||
| private static final String STANDARD = "standard"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in this file are not related to the original purpose of this PR. This is just a small clean-up triggered by some changes in Utils.java class.
|
Currently, the tests are failing because there are different number of discovered tests with and without This only happens if the tests are annotated with annotations like Test ids discovered with dry-run: |
|
|
@sbrannen can we somehow extend I see that If that idea is not possible to achieve for some reason, do you have some other proposal? |
Problem: At the moment, every time we run native tests (with both Maven or Gradle), we must run tests on JVM first, in order to collect
test-idsrequired for native run. With more complex tests, this additional step increases time required for tests execution.Idea: We should use JUnit's dry-run mode to just collect
test-idswithout executing tests on JVM.Solution: we can set
junit.platform.execution.dryRun.enabledsystem property to true when executing tests on JVM (maven change, gradle change).NOTE: Since this approach changes the default behavior, we should bump major version for the next release.