fix: accessible returns wrong permission when there are multiple#2099
Merged
fix: accessible returns wrong permission when there are multiple#2099
Conversation
spaenleh
changed the title
spaenleh
force-pushed
the
fix-accessible-permission
branch
from
008adff to
5e7eebf
Compare
|
spaenleh
added a commit
that referenced
this pull request
Mar 10, 2026
* fix: add test that fails * fix: add code that fixes the issue * fix: itemPublished tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I fix a bug where the accessible call would always return the first membership that was found without checking that it is the correct one for the user.
I added a test that ensure this fails before the fix and passes after.
This should fix issues for people that have shared item in their home, where they are not admin, but they are shown the option to perform administrative tasks.
fix #2100