Open
Conversation
Author
|
Is it possible to review this PR please? It blocks our progress and we have 2 more repositories to propagate these changes to (terraform provider and crossplane provider). |
febd5a2 to
52b9a03
Compare
Author
|
just a friendly reminder about this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the url in the Webhook configuration a secure field. Addressing #430
Note
Medium Risk
Touches notification delivery configuration by changing how webhook URLs are sourced and validated; mistakes could break existing webhook setups if secret resolution is misconfigured.
Overview
Makes the Webhook contact point
urla secret/secure field. Webhook config parsing now always resolvesurlviadecryptFn("url", ...), allowing the URL to be provided (or overridden) from secure settings and failing if the decrypted URL is empty.Updates schema secret-field expectations and expands webhook config tests/fixtures to cover URL-from-secrets and URL override behavior.
Written by Cursor Bugbot for commit 52b9a03. This will update automatically on new commits. Configure here.