Skip to content

Make Webhook URL secret#433

Open
chesster88 wants to merge 1 commit intografana:mainfrom
chesster88:make_webhook_url_secure_field
Open

Make Webhook URL secret#433
chesster88 wants to merge 1 commit intografana:mainfrom
chesster88:make_webhook_url_secure_field

Conversation

@chesster88
Copy link

@chesster88 chesster88 commented Dec 3, 2025

This PR makes the url in the Webhook configuration a secure field. Addressing #430


Note

Medium Risk
Touches notification delivery configuration by changing how webhook URLs are sourced and validated; mistakes could break existing webhook setups if secret resolution is misconfigured.

Overview
Makes the Webhook contact point url a secret/secure field. Webhook config parsing now always resolves url via decryptFn("url", ...), allowing the URL to be provided (or overridden) from secure settings and failing if the decrypted URL is empty.

Updates schema secret-field expectations and expands webhook config tests/fixtures to cover URL-from-secrets and URL override behavior.

Written by Cursor Bugbot for commit 52b9a03. This will update automatically on new commits. Configure here.

@chesster88 chesster88 requested a review from a team as a code owner December 3, 2025 08:13
@github-project-automation github-project-automation bot moved this to In review in Alerting Dec 3, 2025
@CLAassistant
Copy link

CLAassistant commented Dec 3, 2025

CLA assistant check
All committers have signed the CLA.

@chesster88
Copy link
Author

Is it possible to review this PR please? It blocks our progress and we have 2 more repositories to propagate these changes to (terraform provider and crossplane provider).

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before Autofix could start.

@chesster88 chesster88 force-pushed the make_webhook_url_secure_field branch from febd5a2 to 52b9a03 Compare February 12, 2026 07:35
@chesster88
Copy link
Author

just a friendly reminder about this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants