fix: target kubernetes mirror pod logs#52
Open
adamhackl wants to merge 3 commits intografana:mainfrom
Open
Conversation
tim-shane
requested review from
bentonam,
erikbaranowski and
mattdurham
as code owners
adamhackl
force-pushed
the
mirror-pod-logs
branch
from
6ab7b26 to
ea7ae6f
Compare
bentonam
requested changes
Jan 17, 2025
Collaborator
bentonam
left a comment
bentonam
left a comment
There was a problem hiding this comment.
@adamhackl thank you for the contribution
Co-authored-by: Aaron <bentonam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kubernetes mirror pods (kube-apiserver, kube-controller-manager, kube-scheduler, kube-vip, etcd) don't use the same directory pattern for their log files. Regular kubernetes pods work with the structure
/var/log/pods/*<pod uid>/<container name>/*.log, but mirror pods use the mirror hash in place of the pod uid. This fix should use the mirror hash if the annotation is available, otherwise it uses the pod uid.