fix: frontend - scheduler race condition when scheduler is not responding to INIT #19540
+176
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There can be a race condition when the frontend worker connect to the scheduler and the scheduler is in a
RUNNINGstate but not yet in arunStateas its not in the ReplicationSet yet.This leads to a state where the frontend does not receive an
OKon itsINITrequest therefore hanging and not forwarding querying requests.Which issue(s) this PR fixes:
Fixes #19528
Special notes for your reviewer:
This PR has currently to commits mitigating the issue
RUNNINGbut not inshouldRun(which also does not mean it should be shutting down) it replies to theINITwith anERRORalso triggering the frontend to retry to connect.One note regarding fix 1:
The tests actually works without the fix ( 😦 ) for some reason in the test run the loop receive is somehow canceled/time-outed after ~1m21, but this is not the behavior in our prod system but I'm quite sure that this is the issue, if you have any idea why this is happening please let me know. It may be different grpc server setups, as the test does
grpc.NewServerwhile in the main server there is a lot of extra configChecklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR