Skip to content

feat!: Upgrade to Binaryen v118 #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2025
Merged

feat!: Upgrade to Binaryen v118 #204

merged 3 commits into from
Nov 1, 2025
+43 −561

Conversation

@ospencer
Copy link
Member

@ospencer ospencer commented Mar 1, 2025

@ospencer ospencer self-assigned this Mar 1, 2025
@ospencer ospencer force-pushed the oscar/117 branch 3 times, most recently from e8ff14a to 7cc3006 Compare May 18, 2025 02:44
@ospencer ospencer changed the base branch from oscar/117 to master October 29, 2025 16:24
spotandjake
spotandjake reviewed Oct 29, 2025
View reviewed changes
Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to rebase and we need to pull out the changes that are not related to 118 however the changes in src/ and test/ make sense to me looking at the changes to binaryen.

@spotandjake spotandjake mentioned this pull request Oct 29, 2025
Closed
@ospencer ospencer changed the base branch from master to main October 30, 2025 15:19
@ospencer ospencer marked this pull request as ready for review October 30, 2025 16:22
spotandjake
spotandjake approved these changes Oct 31, 2025
View reviewed changes
Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Note:
We are not planning to, but if we are merging this into main, we should probably use the local esy package.

Opam ci still needs to pass after the releases are merged as well.

@ospencer ospencer merged commit 6a5d0e8 into main Nov 1, 2025
24 checks passed
@ospencer ospencer deleted the oscar/118 branch November 1, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spotandjake spotandjake spotandjake approved these changes

Assignees

@ospencer ospencer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ospencer @spotandjake