feat!: Upgrade to Binaryen v122 #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This should allow us to drop this line in our ci test binaryen.ml/.github/workflows/opam.yml Line 39 in c75dd54 |
ospencer
force-pushed
the
oscar/122
branch
2 times, most recently
from
a918259 to
b8876c4
Compare
spotandjake
approved these changes
Nov 1, 2025
Member
spotandjake
left a comment
spotandjake
left a comment
There was a problem hiding this comment.
The physical changes look good to me here.
ospencer
force-pushed
the
oscar/122
branch
2 times, most recently
from
cae1498 to
a4bb843
Compare
spotandjake
reviewed
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full diff here: WebAssembly/binaryen@version_121...version_122
No API changes.
This spookily segfaulted when I ran the tests but was fine when I manually ran the test binary.