Conversation
lmeyerov
reviewed
Jul 7, 2025
|
|
||
| //Initial frame load and settings | ||
| const iframeRef = generateIframeRef({ | ||
| const [hasInitRef, setHasInitRef] = useState(false); |
Contributor
There was a problem hiding this comment.
nit: more legible when all state are up top together
lmeyerov
reviewed
Jul 7, 2025
| .pipe( | ||
| tap(() => { | ||
| if (isFirst) { | ||
| setHasInitRef(true); |
Contributor
There was a problem hiding this comment.
can we encapsulate the fix into client-api , and leave react out of it, e.g., no g object until client-api is ready?
aucahuasi
reviewed
Jul 7, 2025
aucahuasi
reviewed
Jul 7, 2025
Contributor
aucahuasi
left a comment
aucahuasi
left a comment
There was a problem hiding this comment.
Thanks! I left a comment https://github.com/graphistry/graphistry-js/pull/189/files#r2191115634
mj3cheun
force-pushed
the
dev/falcor-fixes
branch
from
b6f10fd to
aad535f
Compare
lmeyerov
reviewed
Jul 9, 2025
| url, | ||
| iframeStyle, iframeClassName, iframeProps, allowFullScreen | ||
| ]); | ||
| }, []); |
Contributor
There was a problem hiding this comment.
this feels a bit risky, if there's a new iframe, we need to reconnect, right?
maybe we should do something like: if (any?) params undefined (vs ''), do nothing, to avoid premature loads. Right now it's just if (iframe && dataset), which may not check enough
Maybe do a few page loads to print what's going on here?
I can imagine:
- Initial frame loads have empty params till filled out, so need to suppress
- Later loads might some reason have empty and need suppressing? unclear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.