fix: cleanup TAPCollectorAuthorizationAlreadyRevoked#1089
Closed
matiasedgeandnode wants to merge 1 commit intohorizonfrom
Closed
fix: cleanup TAPCollectorAuthorizationAlreadyRevoked#1089matiasedgeandnode wants to merge 1 commit intohorizonfrom
matiasedgeandnode wants to merge 1 commit intohorizonfrom
Conversation
fix: cleanup TAPCollectorAuthorizationAlreadyRevoked
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Member
|
I like what you did with Authorizable! Want to PR it into |
Contributor
Author
|
Please look at #1110 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply cleans up what's already there, but if you would consider a slightly bigger re-write, maybe the collector would benefit from a
modifier onlyAuthorized(address _signer)forthawSigner,cancelThawSignerandrevokeAuthorizedSignerlike what's proposed by #1085 -> here.