Skip to content

Compiler upgrade 0.8.34 #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RembrandtK wants to merge 2 commits into from
Closed

Compiler upgrade 0.8.34 #1294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
511cd70
chore: remove unused DataServiceRescuable and Denominations
RembrandtK Feb 26, 2026
302ac40
chore: upgrade Solidity compiler from 0.8.33 to 0.8.34
RembrandtK Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 docs/CompilerUpgrade0833.md → docs/archive/CompilerUpgrade0833.md
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/contracts/contracts/governance/Controller.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later

pragma solidity ^0.7.6 || 0.8.27 || 0.8.33;
pragma solidity ^0.7.6 || 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable gas-indexed-events, gas-small-strings
Expand Down
2 changes: 1 addition & 1 deletion packages/contracts/contracts/governance/Governed.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later

pragma solidity ^0.7.6 || 0.8.27 || 0.8.33;
pragma solidity ^0.7.6 || 0.8.27 || 0.8.34;

/* solhint-disable gas-custom-errors */ // Cannot use custom errors with 0.7.6

Expand Down
2 changes: 1 addition & 1 deletion packages/contracts/contracts/governance/Pausable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later

pragma solidity ^0.7.6 || 0.8.27 || 0.8.33;
pragma solidity ^0.7.6 || 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable gas-indexed-events
Expand Down
2 changes: 1 addition & 1 deletion packages/contracts/contracts/rewards/RewardsManagerStorage.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable named-parameters-mapping

pragma solidity ^0.7.6 || 0.8.27 || 0.8.33;
pragma solidity ^0.7.6 || 0.8.27 || 0.8.34;

import { IIssuanceAllocationDistribution } from "@graphprotocol/interfaces/contracts/issuance/allocate/IIssuanceAllocationDistribution.sol";
import { IRewardsEligibility } from "@graphprotocol/interfaces/contracts/issuance/eligibility/IRewardsEligibility.sol";
Expand Down
2 changes: 1 addition & 1 deletion packages/contracts/contracts/upgrades/GraphProxy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later

pragma solidity ^0.7.6 || 0.8.27 || 0.8.33;
pragma solidity ^0.7.6 || 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable gas-small-strings
Expand Down
2 changes: 1 addition & 1 deletion packages/contracts/contracts/upgrades/GraphProxyAdmin.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later

pragma solidity ^0.7.6 || 0.8.27 || 0.8.33;
pragma solidity ^0.7.6 || 0.8.27 || 0.8.34;

/* solhint-disable gas-custom-errors */ // Cannot use custom errors with 0.7.6

Expand Down
2 changes: 1 addition & 1 deletion packages/contracts/contracts/upgrades/GraphProxyStorage.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later

pragma solidity ^0.7.6 || 0.8.27 || 0.8.33;
pragma solidity ^0.7.6 || 0.8.27 || 0.8.34;

/* solhint-disable gas-custom-errors */ // Cannot use custom errors with 0.7.6

Expand Down
2 changes: 1 addition & 1 deletion packages/contracts/contracts/upgrades/GraphUpgradeable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later

pragma solidity ^0.7.6 || 0.8.27 || 0.8.33;
pragma solidity ^0.7.6 || 0.8.27 || 0.8.34;

/* solhint-disable gas-custom-errors */ // Cannot use custom errors with 0.7.6

Expand Down
2 changes: 1 addition & 1 deletion packages/contracts/contracts/utils/TokenUtils.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later

pragma solidity ^0.7.6 || 0.8.27 || 0.8.33;
pragma solidity ^0.7.6 || 0.8.27 || 0.8.34;

/* solhint-disable gas-custom-errors */ // Cannot use custom errors with 0.7.6

Expand Down
4 changes: 2 additions & 2 deletions packages/deployment/lib/issuance-deploy-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ async function deployProxyWithOwnImpl(
// Deploy OZ v5 TransparentUpgradeableProxy
// Constructor: (address _logic, address initialOwner, bytes memory _data)
// The proxy creates its own ProxyAdmin owned by initialOwner (governor)
// Use issuance-compiled proxy artifact (0.8.33) for consistent verification
// Use issuance-compiled proxy artifact (0.8.34) for consistent verification
const proxyArtifact = loadTransparentProxyArtifact()
const proxyResult = await deployFn(
`${contract.name}_Proxy`,
Expand Down Expand Up @@ -447,7 +447,7 @@ async function deployProxyWithSharedImpl(

// Deploy OZ v5 TransparentUpgradeableProxy
// Constructor: (address _logic, address initialOwner, bytes memory _data)
// Use issuance-compiled proxy artifact (0.8.33) for consistent verification
// Use issuance-compiled proxy artifact (0.8.34) for consistent verification
const proxyArtifact = loadTransparentProxyArtifact()
const proxyResult = await deployFn(
`${contract.name}_Proxy`,
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/data-service/DataService.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

import { IDataService } from "@graphprotocol/interfaces/contracts/data-service/IDataService.sol";

Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/data-service/DataServiceStorage.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

/**
* @title DataServiceStorage
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/data-service/extensions/DataServiceFees.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

import { IDataServiceFees } from "@graphprotocol/interfaces/contracts/data-service/IDataServiceFees.sol";
import { ILinkedList } from "@graphprotocol/interfaces/contracts/horizon/internal/ILinkedList.sol";
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/data-service/extensions/DataServiceFeesStorage.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

import { IDataServiceFees } from "@graphprotocol/interfaces/contracts/data-service/IDataServiceFees.sol";

Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/data-service/extensions/DataServicePausableUpgradeable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

import { IDataServicePausable } from "@graphprotocol/interfaces/contracts/data-service/IDataServicePausable.sol";

Expand Down
84 changes: 0 additions & 84 deletions packages/horizon/contracts/data-service/extensions/DataServiceRescuable.sol
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/horizon/contracts/data-service/libraries/ProvisionTracker.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable gas-strict-inequalities
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/data-service/utilities/ProvisionManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable gas-indexed-events
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/data-service/utilities/ProvisionManagerStorage.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

/**
* @title Storage layout for the {ProvisionManager} helper contract.
Expand Down
25 changes: 0 additions & 25 deletions packages/horizon/contracts/libraries/Denominations.sol
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/horizon/contracts/libraries/LibFixedMath.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

// SPDX-License-Identifier: Apache-2.0

pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable function-max-lines, gas-strict-inequalities
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/libraries/LinkedList.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later

pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable gas-increment-by-one, gas-strict-inequalities
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/libraries/MathUtils.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable gas-strict-inequalities

pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

/**
* @title MathUtils Library
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/libraries/PPMMath.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable gas-strict-inequalities
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/libraries/UintRange.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable gas-strict-inequalities
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/payments/GraphPayments.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable function-max-lines
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/payments/PaymentsEscrow.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable gas-strict-inequalities
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/payments/collectors/GraphTallyCollector.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable gas-small-strings
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/staking/HorizonStaking.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// solhint-disable gas-increment-by-one
// solhint-disable function-max-lines

pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

import { IGraphToken } from "@graphprotocol/interfaces/contracts/contracts/token/IGraphToken.sol";
import { IHorizonStakingMain } from "@graphprotocol/interfaces/contracts/horizon/internal/IHorizonStakingMain.sol";
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/staking/HorizonStakingBase.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable gas-strict-inequalities

pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

import { IHorizonStakingTypes } from "@graphprotocol/interfaces/contracts/horizon/internal/IHorizonStakingTypes.sol";
import { IHorizonStakingBase } from "@graphprotocol/interfaces/contracts/horizon/internal/IHorizonStakingBase.sol";
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/staking/HorizonStakingExtension.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later

pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable function-max-lines, gas-strict-inequalities
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/staking/HorizonStakingStorage.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later

pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// forge-lint: disable-start(mixed-case-variable)
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/staking/libraries/ExponentialRebates.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later

pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// forge-lint: disable-start(unsafe-typecast)
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/staking/utilities/Managed.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later

pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

import { GraphDirectory } from "../../utilities/GraphDirectory.sol";

Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/utilities/Authorizable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

// TODO: Re-enable and fix issues when publishing a new version
// solhint-disable gas-strict-inequalities
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/utilities/GraphDirectory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later

pragma solidity 0.8.27 || 0.8.33;
pragma solidity 0.8.27 || 0.8.34;

import { IGraphToken } from "@graphprotocol/interfaces/contracts/contracts/token/IGraphToken.sol";
import { IHorizonStaking } from "@graphprotocol/interfaces/contracts/horizon/IHorizonStaking.sol";
Expand Down
Loading
Loading