Skip to content

Indexing payments with escrow management and post-Horizon cleanup #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RembrandtK wants to merge 11 commits into from

refactor: typed interfaces, escrow-centric naming, and code quality

1013fb0
Select commit
Loading
Failed to load commit list.
Closed

Indexing payments with escrow management and post-Horizon cleanup #1300

refactor: typed interfaces, escrow-centric naming, and code quality
1013fb0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 28, 2026 in 0s

89.96% (+1.40%) compared to ddee12b

View this Pull Request on Codecov

89.96% (+1.40%) compared to ddee12b

Details

Codecov Report

❌ Patch coverage is 97.42268% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.96%. Comparing base (ddee12b) to head (1013fb0).

Files with missing lines Patch % Lines
...ntracts/payments/collectors/RecurringCollector.sol 93.33% 6 Missing and 6 partials ⚠️
...s/horizon/contracts/staking/HorizonStakingBase.sol 87.50% 2 Missing ⚠️
...n/contracts/data-service/libraries/StakeClaims.sol 96.15% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
+ Coverage   88.55%   89.96%   +1.40%     
==========================================
  Files          75       79       +4     
  Lines        4615     4953     +338     
  Branches      981     1052      +71     
==========================================
+ Hits         4087     4456     +369     
+ Misses        507      464      -43     
- Partials       21       33      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov