-
Notifications
You must be signed in to change notification settings - Fork 91
feat(console): Create backend endpoint for updating a section #14143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(console): Create backend endpoint for updating a section #14143
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
jourdiw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I try to avoid mocking the use cases for the resource tests. One of the great advantages with the Onion architecture is that we can have better confidence for the end to end functionality.
WDYT about not mocking the use cases for the resources?
.../main/java/io/gravitee/apim/core/portal_page/use_case/UpdatePortalNavigationItemUseCase.java
Outdated
Show resolved
Hide resolved
.../main/java/io/gravitee/apim/core/portal_page/use_case/UpdatePortalNavigationItemUseCase.java
Show resolved
Hide resolved
...gravitee/rest/api/management/v2/rest/resource/environment/PortalNavigationItemsResource.java
Outdated
Show resolved
Hide resolved
...gravitee/rest/api/management/v2/rest/resource/environment/PortalNavigationItemsResource.java
Outdated
Show resolved
Hide resolved
ddfc638 to
6c9a022
Compare
I agree. This was already done, so i just added my changes below that. I have removed all the new created use cases now and mocking the in-memory crud and other services. |
389f4f0 to
db584b1
Compare
...avitee-apim-rest-api-management-v2-rest/src/main/resources/openapi/openapi-environments.yaml
Outdated
Show resolved
Hide resolved
...e/rest/api/management/v2/rest/resource/environment/PortalNavigationItemResource_PutTest.java
Outdated
Show resolved
Hide resolved
...e/rest/api/management/v2/rest/resource/environment/PortalNavigationItemResource_PutTest.java
Outdated
Show resolved
Hide resolved
...pi-service/src/main/java/io/gravitee/apim/core/portal_page/model/PortalNavigationFolder.java
Outdated
Show resolved
Hide resolved
...ravitee/apim/core/portal_page/domain_service/CreatePortalNavigationItemValidatorService.java
Outdated
Show resolved
Hide resolved
...avitee-apim-rest-api-management-v2-rest/src/main/resources/openapi/openapi-environments.yaml
Show resolved
Hide resolved
...avitee-apim-rest-api-management-v2-rest/src/main/resources/openapi/openapi-environments.yaml
Outdated
Show resolved
Hide resolved
.../gravitee/rest/api/management/v2/rest/resource/environment/PortalNavigationItemResource.java
Show resolved
Hide resolved
91b779e to
c4ee44b
Compare
20b059c to
9fca7c6
Compare
.../src/test/java/io/gravitee/apim/rest/api/automation/spring/ResourceContextConfiguration.java
Show resolved
Hide resolved
...avitee-apim-rest-api-management-v2-rest/src/main/resources/openapi/openapi-environments.yaml
Outdated
Show resolved
Hide resolved
...a/io/gravitee/apim/core/portal_page/domain_service/PortalNavigationItemValidatorService.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/io/gravitee/apim/core/portal_page/model/UpdatePortalNavigationItem.java
Outdated
Show resolved
Hide resolved
...a/io/gravitee/apim/core/portal_page/domain_service/PortalNavigationItemValidatorService.java
Outdated
Show resolved
Hide resolved
c686067 to
62b8c64
Compare
jourdiw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
A couple things if you are feeling 🚀 :
- Use core-based exceptions in the services rather than the
InvalidDataException - Removing page content id from the Update model in the core package to match what is expected from the Resource 👍
10d1d1d to
1faa3d6
Compare
Issue
https://gravitee.atlassian.net/browse/APIM-11947
Description
{{baseURL}}/portal-navigation-items/{{navigationId}}sample payload for update page with required fields
Screen.Recording.2025-11-21.at.11.57.12.mov
Response
Additional context