fix: set primary owner for v4 api import

[nive1980]

Issue

https://gravitee.atlassian.net/browse/APIM-11286

Description

Setting the primary owner for API import as mentioned in the import definition

[gaurav-gravitee]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly implements setting the primary owner during a v4 API import. The changes in the domain service and the new tests are well-implemented. I've suggested a small refactoring in the ImportExportApiMapper to improve code clarity and prevent a potential NullPointerException.

[phiz71]

Global question: what if the primary owner you are getting from the input payload doesn't exist in the database? (For isntance an export made from another organisation).
The risk here is to have an API with an unknown user as PO.

I think you should check how this use case is handled for V2 import. AFAIR, the user doing the import becomes the new PO if the one in the api definition being imported is not found.
Could you verify please?

[nive1980]

Global question: what if the primary owner you are getting from the input payload doesn't exist in the database? (For isntance an export made from another organisation). The risk here is to have an API with an unknown user as PO.

I think you should check how this use case is handled for V2 import. AFAIR, the user doing the import becomes the new PO if the one in the api definition being imported is not found. Could you verify please?

In V2 apis, if the user does not exist in the database it sets the PO to the user performing the import, but in case of V4 apis, if the user does not exist we throw an exception saying the user does not exist and halt the import. So let me know if this needs to be changed for V4.

[phiz71]

Global question: what if the primary owner you are getting from the input payload doesn't exist in the database? (For isntance an export made from another organisation). The risk here is to have an API with an unknown user as PO.
I think you should check how this use case is handled for V2 import. AFAIR, the user doing the import becomes the new PO if the one in the api definition being imported is not found. Could you verify please?

In V2 apis, if the user does not exist in the database it sets the PO to the user performing the import, but in case of V4 apis, if the user does not exist we throw an exception saying the user does not exist and halt the import. So let me know if this needs to be changed for V4.

No it's ok, we can go with this 👍🏻