-
Notifications
You must be signed in to change notification settings - Fork 92
feat(portal): refactor to use dynamic portal navigation items and update related services #14165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(portal): refactor to use dynamic portal navigation items and update related services #14165
Conversation
Summary of ChangesHello @dev-marek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a significant refactoring of the portal's navigation system. The primary goal is to transition from a static menu link service to a dynamic navigation item service, enabling more flexible and configurable navigation within the portal. This change introduces a new data structure for navigation items, allowing them to be categorized as pages, folders, or external links, and updates all relevant services and UI components to consume and render these new dynamic items. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the portal menu links to use a more dynamic and structured PortalNavigationItem system. This is a great improvement, replacing the old PortalMenuLinksService with PortalNavigationItemsService and consistently updating all related components and services. The new data structures and service are well-defined. I have one suggestion to improve the implementation in the desktop navigation bar template for consistency and correctness.
...apim-portal-webui-next/src/components/nav-bar/desktop-nav-bar/desktop-nav-bar.component.html
Outdated
Show resolved
Hide resolved
658abb1 to
fd4d890
Compare
...apim-portal-webui-next/src/components/nav-bar/desktop-nav-bar/desktop-nav-bar.component.html
Outdated
Show resolved
Hide resolved
...e-apim-portal-webui-next/src/components/nav-bar/mobile-nav-bar/mobile-nav-bar.component.html
Outdated
Show resolved
Hide resolved
gravitee-apim-portal-webui-next/src/services/portal-navigation-items.service.ts
Outdated
Show resolved
Hide resolved
gravitee-apim-portal-webui-next/src/services/portal-navigation-items.service.ts
Show resolved
Hide resolved
a9349e0 to
cd31ef2
Compare
2035fcb to
53dbc28
Compare
gravitee-apim-portal-webui-next/src/services/portal-navigation-items.service.ts
Outdated
Show resolved
Hide resolved
53dbc28 to
0feeceb
Compare
Issue
https://gravitee.atlassian.net/browse/APIM-11518
Description
Additional context