Skip to content

Conversation

@dev-marek
Copy link
Contributor

@dev-marek dev-marek commented Nov 24, 2025

Issue

https://gravitee.atlassian.net/browse/APIM-11518

Description

image

Additional context

@dev-marek dev-marek requested a review from a team as a code owner November 24, 2025 13:54
@gemini-code-assist
Copy link

Summary of Changes

Hello @dev-marek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a significant refactoring of the portal's navigation system. The primary goal is to transition from a static menu link service to a dynamic navigation item service, enabling more flexible and configurable navigation within the portal. This change introduces a new data structure for navigation items, allowing them to be categorized as pages, folders, or external links, and updates all relevant services and UI components to consume and render these new dynamic items.

Highlights

  • New Dynamic Navigation System: Introduced PortalNavigationItemsService and PortalNavigationItem entity to support dynamic navigation links, replacing the older PortalMenuLinksService.
  • Enhanced Navigation Item Types: The new PortalNavigationItem can represent different types of navigation entries: PAGE, FOLDER, or LINK, allowing for more flexible portal navigation.
  • Service and Component Updates: Core application components (AppComponent, LogInComponent, LogOutComponent) and configuration (app.config.ts) have been updated to utilize the new PortalNavigationItemsService.
  • UI Rendering Logic Refinement: Navigation bar templates (desktop and mobile) now dynamically render links based on the PortalNavigationItem type, using href for external links and routerLink for internal pages/folders.
  • Codebase Modernization: The old PortalMenuLinksService and its associated test file have been removed, and a new PortalNavigationItemsService with its dedicated test file has been added, reflecting a more robust and extensible architecture.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the portal menu links to use a more dynamic and structured PortalNavigationItem system. This is a great improvement, replacing the old PortalMenuLinksService with PortalNavigationItemsService and consistently updating all related components and services. The new data structures and service are well-defined. I have one suggestion to improve the implementation in the desktop navigation bar template for consistency and correctness.

Base automatically changed from apim-11518-make-navigation-items-dynamic-papi to master November 25, 2025 12:59
@dev-marek dev-marek force-pushed the apim-11518-make-navigation-items-dynamic-fe branch from 658abb1 to fd4d890 Compare November 25, 2025 13:02
@dev-marek dev-marek force-pushed the apim-11518-make-navigation-items-dynamic-fe branch from a9349e0 to cd31ef2 Compare November 26, 2025 10:36
@dev-marek dev-marek requested a review from jourdiw November 26, 2025 11:52
@dev-marek dev-marek force-pushed the apim-11518-make-navigation-items-dynamic-fe branch 4 times, most recently from 2035fcb to 53dbc28 Compare November 27, 2025 13:47
@dev-marek dev-marek force-pushed the apim-11518-make-navigation-items-dynamic-fe branch from 53dbc28 to 0feeceb Compare November 28, 2025 08:23
@dev-marek dev-marek merged commit 2505771 into master Nov 28, 2025
13 checks passed
@dev-marek dev-marek deleted the apim-11518-make-navigation-items-dynamic-fe branch November 28, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants