Skip to content

Conversation

@jourdiw
Copy link
Contributor

@jourdiw jourdiw commented Nov 24, 2025

Issue

https://gravitee.atlassian.net/browse/APIM-11513

Description

This Pull Request enhances the UI and interaction features for the tree component in the Gravitee APIM Console Web UI. It introduces accessibility improvements, code refactoring, design adjustments, and panel resizing functionality for better user experience and maintainability.

  • Updated tree component (tree-node.component) with better accessibility attributes (e.g., aria-expanded, aria-selected) and smoother interactions through event handling.
  • Introduced new SCSS styles with modernized design (e.g., material theme, revised padding/margins, responsive layout adjustments).
  • Added resizing functionality for the navigation panel (portal-navigation-items.component) with minimum and maximum width constraints.
  • Cleaned up redundant HTML and CSS elements for better structure and performance (e.g., removed outdated classes, card wrappers in certain templates).
  • Refactored and updated related unit tests to reflect UI changes (e.g., selector updates for test cases).
Screen.Recording.2025-11-25.at.16.02.09.mov

Additional context

@jourdiw jourdiw force-pushed the apim-11513-implement-ui-design branch 5 times, most recently from 562762b to 17c1cbb Compare November 24, 2025 19:45
@jourdiw
Copy link
Contributor Author

jourdiw commented Nov 24, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request brings significant UI and interaction enhancements to the tree component and introduces a resizable navigation panel. The changes include modernizing styles, improving accessibility attributes, and refactoring for better maintainability. The code quality is high, especially the implementation of the panel resizing logic which correctly uses NgZone for performance. I have a few suggestions to further improve accessibility, correctness, and code consistency.

@jourdiw jourdiw force-pushed the apim-11513-implement-ui-design branch from 17c1cbb to b241ec9 Compare November 25, 2025 11:01
Copy link
Contributor Author

@jourdiw jourdiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

responses!

@jourdiw jourdiw marked this pull request as ready for review November 25, 2025 11:03
@jourdiw jourdiw requested a review from a team as a code owner November 25, 2025 11:03
@jourdiw jourdiw force-pushed the apim-11513-implement-ui-design branch from b241ec9 to 58a1583 Compare November 25, 2025 15:24
@kovaren kovaren self-requested a review November 25, 2025 17:00
@jourdiw jourdiw merged commit 4cbb8f1 into master Nov 25, 2025
11 of 12 checks passed
@jourdiw jourdiw deleted the apim-11513-implement-ui-design branch November 25, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants