Open
Conversation
The following changes in particular may be helpful: - Fixes Explorer. - Introduces `System::History`. - Introduces `assert_properties` helper.
I loaded `ConcordeSystem::simple()` into Stateright's Explorer and noticed that the latest version isn't sending any messages. This commit simply adds a regression test, which is currently failing. The commit also adds `#derive(Clone)` to `ConcordeActor` and `ConcordeSystem` as those are necessary for using the Explorer.
Author
|
@graydon I noticed that a recent change altered a filter to require an ordering relationship between items, whereas the older code would allow diff --git a/src/participant.rs b/src/participant.rs
index 35f141c..6b4bca9 100644
--- a/src/participant.rs
+++ b/src/participant.rs
@@ -119,7 +119,10 @@ impl<ObjLD: LatticeDef + 'static, Peer: DefTraits + 'static> Participant<ObjLD,
.new_opinion
.proposed_configs
.iter()
- .filter(|u| { *u >= commit_cfg })
+ .filter(|u| {
+ <crate::cfg::CfgLD<Peer> as LatticeDef>::partial_order(&u.value, &commit_cfg.value)
+ != Some(std::cmp::Ordering::Less)
+ })
.cloned()
.collect();
}That change results in messages being sent, but then the liveness property is violated, which leads me to think that I might not be on the right track. Thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds upon #1
I loaded
ConcordeSystem::simple()into Stateright's Explorer andnoticed that the latest version isn't sending any messages. This commit
simply adds a regression test, which is currently failing.
The commit also adds
#derive(Clone)toConcordeActorandConcordeSystemas those are necessary for using the Explorer.