fix(AC-333): verify discovery path returns correct scenario_type for all families#449
Merged
jayscambler merged 2 commits intomainfrom Mar 18, 2026
Merged
Conversation
…all families The in-repo discovery path already returns the correct scenario_type for negotiation scenarios via family.scenario_type_marker. AC-333's L9 failure is in the external escalation_l9.py which uses a hardcoded allowlist instead of get_valid_scenario_types(). Added 3 verification tests: - Negotiation scenario returns scenario_type="negotiation" from discovery - All families' scenario_type_marker values are in get_valid_scenario_types() - Marker/name consistency check (catches drift between family name and marker)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verifies that the in-repo discovery path (
_build_scenario_info) returns the correctscenario_typefor negotiation and all other families.Finding
The in-repo code is already correct —
_build_scenario_infousesfamily.scenario_type_markerwhich returns"negotiation"for negotiation scenarios. The L9 failure is in the externalescalation_l9.pyscript which has a hardcoded allowlist instead of usingget_valid_scenario_types().Tests Added
scenario_type="negotiation"from discovery pathscenario_type_markervalues are inget_valid_scenario_types()Test plan