Skip to content

Conversation

@ldhtnp
Copy link
Contributor

@ldhtnp ldhtnp commented Apr 1, 2025

Added the ability to essentially link related sources together. When logged in, a button to do so appears next to the existing "Suggest a New Source" button.

More information can be found in issue #1196

Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments about some design decisions that may need some further thought. There are also some things I noticed when trying out the new form:
Screenshot 2025-04-01 at 11 38 36 AM

  • The icon in the form header needs to be changed to the source icon
  • The placement of the "Add a related source" button is not ideal. That space is generally reserved for general actions related to this type of entity while action for a specific entity would appear where the pubmed linkout currently is
  • The cancel button is positioned on top of the submit button instead of next to it

There is currently no way to view source links as far as I can tell. Depending on wether we decide that directionality is important we should show both the sources that are linked to the current source as well as the sources that have linked the current source to them (basically you want to be able to see the same link from either source).

We should also think about whether we need some ability to delete source linkages

@acoffman acoffman added the new-feature PR Label for newly added features. Will appear in release notes. label Apr 24, 2025
@susannasiebert susannasiebert linked an issue Jun 9, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature PR Label for newly added features. Will appear in release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support "related sources" relationship

3 participants