-
Notifications
You must be signed in to change notification settings - Fork 6
Added the ability to add related sources #1219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
susannasiebert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments about some design decisions that may need some further thought. There are also some things I noticed when trying out the new form:

- The icon in the form header needs to be changed to the source icon
- The placement of the "Add a related source" button is not ideal. That space is generally reserved for general actions related to this type of entity while action for a specific entity would appear where the pubmed linkout currently is
- The cancel button is positioned on top of the submit button instead of next to it
There is currently no way to view source links as far as I can tell. Depending on wether we decide that directionality is important we should show both the sources that are linked to the current source as well as the sources that have linked the current source to them (basically you want to be able to see the same link from either source).
We should also think about whether we need some ability to delete source linkages
Added the ability to essentially link related sources together. When logged in, a button to do so appears next to the existing "Suggest a New Source" button.
More information can be found in issue #1196