Skip to content

Shutdown quiesced conn managers when removed from pool #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glbrntt merged 1 commit into from
Dec 8, 2025
Merged

Shutdown quiesced conn managers when removed from pool #2268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/GRPC/ConnectionManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,6 +1218,11 @@ extension ConnectionManager {
internal func startConnecting() {
self.manager.startConnecting()
}

/// Shutdown the manager now.
internal func shutdownNow() {
self.manager._shutdown(mode: .forceful, promise: self.manager.eventLoop.makePromise())
}
}
}

Expand Down
1 change: 1 addition & 0 deletions Sources/GRPC/ConnectionPool/ConnectionPool.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,6 +760,7 @@ extension ConnectionPool: ConnectionManagerConnectivityDelegate {
assert(hadActiveConnection)
if let removed = self._connections.removeValue(forKey: manager.id) {
removed.manager.sync.http2Delegate = nil
removed.manager.sync.shutdownNow() // Manager may have internal state to tear down.
self.delegate?.connectionClosed(id: .init(removed.manager.id), error: nil)
self.delegate?.connectionRemoved(id: .init(removed.manager.id))
}
Expand Down