This repository was archived by the owner on May 29, 2025. It is now read-only.
Process+extensions.swift and DataChannel+StdioProcess.swift are chang… #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsabran
suggested changes
Apr 28, 2025
Owner
gsabran
left a comment
gsabran
left a comment
There was a problem hiding this comment.
Thanks, this looks great! Can you revert the changes to the Package.resolved ? I don't think they are needed.
…ed to make the Process-dependent functionality only available on platforms where the API exists.
Contributor
Author
|
Hi, I’ve reverted the MCPClientChatDemo/MCPClientChat/MCPClientChat.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved file. It was automatically modified by Xcode when I was testing the build, and I didn’t notice the change. Sorry about that! |
Owner
|
No worries, swift package is a pain to work with... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed to make the Process-dependent functionality only available on platforms where the API exists.
Summary
This PR addresses platform compatibility issues with the Process class by using Swift's conditional compilation to make Process-dependent functionality only available on macOS. This approach leverages compile-time safety rather than runtime errors, resulting in cleaner and more maintainable code.
Details
Changes
Technical Details