-
-
Notifications
You must be signed in to change notification settings - Fork 34
Make custom formatting better #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mendelsshop
wants to merge
14
commits into
gsingh93:master
Choose a base branch
from
mendelsshop:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argument parsing done
Also fixed bug in parser which lead to non interpolated things being interpolated
…n values the parser is getting a drop messy
custom formatting interpolation now follows (mostly) the same rules as `fomat!` custom formatting interpolation now report (mostly) the same errors as `format!` fixed some copy pasted error reporting
format! support also did bit of explanation of how custom formating works
Contributor
Author
|
One idea that I had, was right now the way I am doing it is mostly manually parsing the format string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #37, I Implemented custom formatting using
format_enter/format_exit.I defaulted to using
Displayfor formatting, likeformat!and friends.Sometimes something does not implement
Displayso withformat!you can do:?.This PR allows
format_enter/format_exitto do that and more (whatever other custom formatting options are supported byformat).