-
Notifications
You must be signed in to change notification settings - Fork 1
Build wheels, upload to PyPI, minor bug fixes #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomstoll
wants to merge
41
commits into
guestdaniel:main
Choose a base branch
from
tomstoll:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to compile on install. Added github workflow to build wheels to prepare for publishing on PyPI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks might look like a lot, but there isn't much change to the core functionality. I fixed a couple of minor bugs (line 181 of pyzbc2014.py had 'hsr' where it should've been 'lsr'), but other than that it's mostly restructuring and adding code to build wheels and publish to PyPI so users no longer need to compile anything. There's also more in the diff than really changed, since my editor auto-formatted some things (e.g., stripping the trailing white spaces).
I've updated the README with new (simpler) install instructions, updated dependencies, citing info for the original paper, and instructions for how to contribute.
I'll note that I updated the dependency to python 3.10 since the code uses
matchcase, which was introduced then. This would be easily changed toifelsestatements, but I figured it didn't make sense to change unless it's needed (i.e., if someone needs to use an earlier version of python).It's already up on PyPI (https://pypi.org/project/pyzbc2014/). As described in the README, the wheels will build automatically on a version bump, but I decided to go with a manual trigger for publishing to make development/debugging safer.
Let me know if you think any changes are needed.