Skip to content

Conversation

@tomstoll
Copy link

This PR looks might look like a lot, but there isn't much change to the core functionality. I fixed a couple of minor bugs (line 181 of pyzbc2014.py had 'hsr' where it should've been 'lsr'), but other than that it's mostly restructuring and adding code to build wheels and publish to PyPI so users no longer need to compile anything. There's also more in the diff than really changed, since my editor auto-formatted some things (e.g., stripping the trailing white spaces).

I've updated the README with new (simpler) install instructions, updated dependencies, citing info for the original paper, and instructions for how to contribute.

I'll note that I updated the dependency to python 3.10 since the code uses match case, which was introduced then. This would be easily changed to if else statements, but I figured it didn't make sense to change unless it's needed (i.e., if someone needs to use an earlier version of python).

It's already up on PyPI (https://pypi.org/project/pyzbc2014/). As described in the README, the wheels will build automatically on a version bump, but I decided to go with a manual trigger for publishing to make development/debugging safer.

Let me know if you think any changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant