Skip to content

All current dependencies should be declared as development#14

Open
arokettu wants to merge 3 commits intogugod:masterfrom
sandfoxme:upstream-13-dependencies-should-be-declared-as-development
Open

All current dependencies should be declared as development#14
arokettu wants to merge 3 commits intogugod:masterfrom
sandfoxme:upstream-13-dependencies-should-be-declared-as-development

Conversation

@arokettu
Copy link
Copy Markdown
Contributor

Fix for #13

  • Gemfile dependencies marked as :development so Jeweler adds them as development dependencies
  • Version constraint for shoulda moved to Gemfile so no duplicate dependencies are generated
  • Gemfile.lock is removed from repo and added to .gitignore. The file should not be committed for gems

I have tested rake gemspec:generate but not committed the new spec as it will be automatically regenerated by the Jeweler release procedure

p.s. Jeweler is deprecated technicalpickles/jeweler#283
Have you thought of moving to Juwelier for example, or using pure Bundler?

@arokettu
Copy link
Copy Markdown
Contributor Author

arokettu commented Jun 20, 2016

Fixed test failure on new rubies
there's no more 'test/unit' in newer ruby versions so test-unit gem should be added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant