Disable phpinfo and serverinfo calls (fixes issue #6)#7
Open
rogerpueyo wants to merge 1 commit intoguifi:masterfrom
Open
Disable phpinfo and serverinfo calls (fixes issue #6)#7rogerpueyo wants to merge 1 commit intoguifi:masterfrom
rogerpueyo wants to merge 1 commit intoguifi:masterfrom
Conversation
miquelmartos
requested changes
Dec 14, 2017
Member
miquelmartos
left a comment
There was a problem hiding this comment.
Si hem de treure opcions, mes val eliminar-ho del codi enlloc de comentar-ho.
la phpinfo es pot eliminar del tot sense problemes.
la opció serverinfo, fixa't que fa una crida a una funció nostra "getServerInfo();" que esta definida en el mateix fitxer, si no s'utilitza també cal esborrar la funció per deixar net el fitxer.
De totes maneres aquest funció jo la mantindria com a opció però eliminant només la informació sensible, deixant només per exemple informació util:
echo "Server id: $SNPGraphServerId\n";
echo "Root zone: $rootZone\n";
echo "CNML source: $CNMLSource\n";
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aquest commit deshabilita les crides phpinfo i serverinfo (https://llistes.guifi.net/sympa/arc/guifi-dev/2017-01/msg00007.html).