Sortable fields with scope:name_of_scope#5
Open
FiloSpaTeam wants to merge 7 commits intoguillaumebriday:masterfrom
Open
Sortable fields with scope:name_of_scope#5FiloSpaTeam wants to merge 7 commits intoguillaumebriday:masterfrom
FiloSpaTeam wants to merge 7 commits intoguillaumebriday:masterfrom
Conversation
…s a lot of problems with Elasticsearch filters for example
Owner
|
Hi! Thanks for the PR 🙌 Can you describe what you're trying to achieve here in the PR's description? thank |
FiloSpaTeam
changed the title
…ion is polymorphic (#2) Keeps using `allowed_includes` but applies `preload` when the relation is polymorphic in order to overcome `ActiveRecord::EagerLoadPolymorphicError: Cannot eagerly load the polymorphic association xxx`.
Could be improved but had to rush to fix a regression
When no `default_sort` is defined for the target class, doesn't remove
previously defined query conditions.
Before this change:
```ruby
MyModel.where(id: 3).apply_sort({})
```
`apply_sort` would remove `where(id: 3)` when `MyModel` doesn't include
the definition of `default_sort`.
This was happening because the empty behavior were returning the model
class instead of an ActiveRecord relation based on the same class,
therefore beaking the scopes chaining.
With this change, the returned object is an ActiveRecord relation even
when no `default_sort` is defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can sort things like this:
EDIT: The array in this position seems needed to filters with dates so reverted.