Skip to content

[Task-7] As a user, I can get the reset password instruction via email#41

Open
gutakk wants to merge 29 commits intofeature/task-27-authenticated-routefrom
feature/task-7-reset-password-backend
Open

[Task-7] As a user, I can get the reset password instruction via email#41
gutakk wants to merge 29 commits intofeature/task-27-authenticated-routefrom
feature/task-7-reset-password-backend

Conversation

@gutakk
Copy link
Copy Markdown
Owner

@gutakk gutakk commented Jun 16, 2021 •
edited
Loading

Resolve #8

What happened 👀

  • Add forgot password page and related components without styling
  • Add forgot password functionalities
  • Fix alert component to be able to render different icons.
  • Add forgot password as a public route
  • Back will redirect to home page
  • Add unit tests

Insight 📝

N/A

Proof Of Work 📹

  • Send the recovery instruction email
    Screen Shot 2564-06-21 at 13 32 06

  • Email
    Screen Shot 2564-06-21 at 13 32 58

  • Validation
    Screen Shot 2564-06-21 at 13 33 12

@gutakk gutakk added this to the 0.3.0 milestone Jun 16, 2021
@gutakk gutakk self-assigned this Jun 16, 2021
@gutakk gutakk linked an issue Jun 16, 2021 that may be closed by this pull request
[Task-7] As a user, I can get the reset password instruction via email #8
Open
@gutakk gutakk force-pushed the feature/task-27-authenticated-route branch from 5f51ab3 to a947482 Compare June 17, 2021 04:56
@gutakk gutakk force-pushed the feature/task-7-reset-password-backend branch from 72298ad to 874c61e Compare June 17, 2021 04:57
@gutakk gutakk force-pushed the feature/task-27-authenticated-route branch from a947482 to 7da4f05 Compare June 17, 2021 08:44
@gutakk gutakk force-pushed the feature/task-7-reset-password-backend branch from 2ec4d6f to cff4f67 Compare June 17, 2021 08:45
@gutakk gutakk requested review from carryall and rafayet-monon June 17, 2021 09:01
@gutakk gutakk marked this pull request as ready for review June 17, 2021 09:04
@gutakk gutakk force-pushed the feature/task-27-authenticated-route branch from 7da4f05 to 101ecff Compare June 18, 2021 09:23
@gutakk gutakk force-pushed the feature/task-7-reset-password-backend branch from cff4f67 to 857a086 Compare June 18, 2021 09:27
@gutakk gutakk force-pushed the feature/task-27-authenticated-route branch from 101ecff to 6864828 Compare June 18, 2021 10:44
@gutakk gutakk force-pushed the feature/task-7-reset-password-backend branch from 857a086 to ee3f7f2 Compare June 18, 2021 10:44
@gutakk gutakk force-pushed the feature/task-27-authenticated-route branch from 6864828 to 30e8ea0 Compare June 18, 2021 11:51
@gutakk gutakk force-pushed the feature/task-7-reset-password-backend branch from ab914cf to baa1f01 Compare June 18, 2021 11:52
rafayet-monon
rafayet-monon reviewed Jun 21, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rafayet-monon rafayet-monon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add appropriate PR descriptions.

@gutakk
Copy link
Copy Markdown
Owner Author

gutakk commented Jun 21, 2021

Please add appropriate PR descriptions.

Updated the PR description. I'm sure that I already updated the description before make it ready for review 🤔

@gutakk gutakk requested a review from rafayet-monon June 21, 2021 06:34
@gutakk gutakk added the @0.4.0 label Jun 21, 2021
@gutakk gutakk modified the milestones: 0.3.0, 0.4.0 Jun 21, 2021
@gutakk gutakk force-pushed the feature/task-27-authenticated-route branch from 30e8ea0 to e01c622 Compare June 21, 2021 08:46
@gutakk gutakk force-pushed the feature/task-7-reset-password-backend branch from baa1f01 to 96e7047 Compare June 21, 2021 08:47
@rafayet-monon
Copy link
Copy Markdown
Collaborator

rafayet-monon commented Jun 22, 2021

Please add appropriate PR descriptions.

Updated the PR description. I'm sure that I already updated the description before make it ready for review 🤔

Don't know what happened but It was not shown to me 🤣

rafayet-monon
rafayet-monon reviewed Jun 22, 2021
View reviewed changes
src/adapters/auth.ts
static forgotPassword = (email: string): Promise<AxiosResponse> => {
/* eslint-disable camelcase */
const requestOptions = {
headers: {
Copy link
Copy Markdown
Collaborator

@rafayet-monon rafayet-monon Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like every request is going to have this portion

headers: {
  'Content-Type': 'application/json'
}

Can we somehow add it requestManager.ts so that it isn't repeated?

Copy link
Copy Markdown
Owner Author

@gutakk gutakk Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not as the requestManager.ts is the generic function. We don't need this header when it comes to GET request or POST request without json body.

Copy link
Copy Markdown
Collaborator

@rafayet-monon rafayet-monon Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the case then how about making it DRY in some other way? As there are more API which will require json body. What do you think?

Copy link
Copy Markdown
Owner Author

@gutakk gutakk Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f8142ea

@gutakk gutakk requested a review from rafayet-monon June 22, 2021 05:33
Gut added 29 commits June 29, 2021 14:05
[Task-7] Add forgot password component
fc0ce42
[Task-7] Add AuthInputField
ed6b7f3
[Task-7] Add forgot password form
c8a65c9
[Task-7] Update sign in to use auth input field
94bcf19
[Task-7] Add forgot password handler and adapter
fbfa6a7
[Task-7] Add forgot password adapter and handler
0382890
[Task-7] Add back button
4ed9f02
[Task-7] Add back function
c34a884
[Task-7] Remove key value return
b3b0b12
[Task-7] Add unit test for AuthInputField
c7d946a
[Task-7] Add back icon and unit test for BackButton
8f6bebe
[Task-7] Update data-test-id to data-testid
ac80824
[Task-7] Update data-testid to data-test-id and add config to let rea…
dd657b9 
…ct testing library look for data-test-id
[Task-7] Get from test id instead
7f74157
[Task-7] Add TODO
0c27d06
[Task-7] Add forgot password page test
8403b33
[Task-7] Add forgot password form unit test
034c0bc
[Task-7] Fix linting
23106cb
[Task-7] Add alert bell icon
1105c50
[Task-7] Add alert unit test
7aaa69f
[Task-7] Add break line
e361db7
[Task-7] Update back button to redirect to home page
d6a820a
[Task-7] Fix lint
0935ad5
[Task-7] disable camel case lint for the whole file
7d28670
[Task-7] Update goBack function name
a836260
[Task-7] Destruct const in the test
47e418c
[Task-7] Add default adapter payload
ec6fd44
[Task-7] Add adapter header
c4d2b1f
[Task-7] Update reset password to use AuthHeader
662db49
@gutakk gutakk force-pushed the feature/task-7-reset-password-backend branch from f8142ea to 662db49 Compare June 29, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafayet-monon rafayet-monon rafayet-monon approved these changes

@carryall carryall Awaiting requested review from carryall

At least 2 approving reviews are required to merge this pull request.

Assignees

@gutakk gutakk

Labels

Bankend feature @0.3.0 @0.4.0

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

[Task-7] As a user, I can get the reset password instruction via email

2 participants

@gutakk @rafayet-monon