Skip to content

Download Statistics on "Frequently Downloaded" page#260

Open
JohannesSeikowsky wants to merge 1 commit intodevfrom
JohannesSeikowsky-patch-9
Open

Download Statistics on "Frequently Downloaded" page#260
JohannesSeikowsky wants to merge 1 commit intodevfrom
JohannesSeikowsky-patch-9

Conversation

@JohannesSeikowsky
Copy link
Contributor

@JohannesSeikowsky JohannesSeikowsky commented Mar 10, 2026

using html tags to hide the Download statistics on the "Frequently Downloaded" page by default, but keeping them easily accessible on click right there.

Means the few people who are used to seeing the statistics there can still do so very easily, but the statistics don't get in the way of normal users who are primarily interested in finding books!

Technically this is a minimal change, only adding characters to the $s string. relatively low-risk I would say (which matters given the situation with the php scripts)

using <details> <summary>  to hide the Download statistics on the "Frequently Downloaded" page by default, but  keeping them easily accessible on click.

Means the few people who are using to seeing them there can still do so easily, but the statistics don't get int he way of normal users who primarily want to find books
@JohannesSeikowsky
Copy link
Contributor Author

JohannesSeikowsky commented Mar 10, 2026

@rtonsing do you think this would be ok to deploy? Or do we have some way of "dry-testing" this change before just to be a bit more certain it doesn't break anything (which seems unlikely to me, but better to be sure if possible)

Copy link
Contributor

@rtonsing rtonsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine to merge to dev, & test at https://dev.gutenberg.org/.

@eshellman
Copy link
Collaborator

could you post images of what this change does? or perhaps the output html files? We currently don't have an easy way to pretest changes in the php files.

@JohannesSeikowsky
Copy link
Contributor Author

Screenshot_2026-03-12_21-20-23

@JohannesSeikowsky
Copy link
Contributor Author

JohannesSeikowsky commented Mar 12, 2026

And if you click on that, it expands to look like the page looks now by default (obviously).

@JohannesSeikowsky
Copy link
Contributor Author

@rtonsing I think you said before that this can be tested on dev. Is that so? If yes, we should do it.
Having the download statistics in the current place is an obvious UX mistake.

@rtonsing
Copy link
Contributor

It is my understanding that merging to dev updates the dev site, but @eshellman would know for sure.

@JohannesSeikowsky
Copy link
Contributor Author

I think we should risk deploying this. It fixes a very obvious UX mistake in a simple way. And in the pretty unlikely event that it should break something, we just roll back immediately (not ideal but not the end of the world)

@JohannesSeikowsky
Copy link
Contributor Author

on a general level we should have proper testing for the php scripts. But that's not a small thing and imo we shouldn't be held back by that for simple change like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants