Skip to content

Conversation

@AllTheSquares
Copy link

Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.

Check off the following to let the reviewers know you've done everything:
[X] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[X] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[X] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[X] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[X] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[X] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:

  • Full render including all the parts
  • A few sentences about the inspiration and challenges
  • BOM
  • Photos of the Schematic, PCB, and case

If you're unsure about the format, make sure to check out this example and follow the format there.

If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!

@vercel
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hackpad ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2025 3:31am

@UnusualTitan711x
Copy link
Contributor

UnusualTitan711x commented Mar 12, 2025

Hi there @AllTheSquares,

Nice Macropad. I love the design. However, there are some issues you'll need to fix with your PR

  • Please remove all libraries that you aren't using. You don't have to upload all the footprints. I couldn't even see all the changes because my browser kept slowing down and crashing because of the huge number of files
  • Please upload images and put them in your README file. You'll need images of your PCB design, schematic, case parts, and fully assembled PCB.
  • Please add the name of your macropad on the bottom of your case

I'm a huge fan of the design 👍

Here is the link for my PR you can use as a guide #405

@AllTheSquares
Copy link
Author

Hi there @AllTheSquares,

Nice Macropad. I love the design. However, there are some issues you'll need to fix with your PR

  • Please remove all libraries that you aren't using. You don't have to upload all the footprints. I couldn't even see all the changes because my browser kept slowing down and crashing because of the huge number of files
  • Please upload images and put them in your README file. You'll need images of your PCB design, schematic, case parts, and fully assembled PCB.
  • Please add the name of your macropad on the bottom of your case

I'm a huge fan of the design 👍

Here is the link for my PR you can use as a guide #405

Sorry for the tardiness, school is a drag! I did it though!

@Overlord-Runt
Copy link
Collaborator

can you please remove the scotto keeps library, and you random junk folder, and your backups. then can you add the raw firmware files to your firmware folder. after that I will do a proper review.( i cant request changes properly but this is official)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants