🧠 Remember login methods from previous logins #11920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampoder
approved these changes
Oct 31, 2025
Member
sampoder
left a comment
sampoder
left a comment
There was a problem hiding this comment.
this looks good to me! thank you for splitting up email & sms
YodaLightsabr
added a commit
that referenced
this pull request
Nov 3, 2025
This reverts commit 3d50486.
YodaLightsabr
added a commit
that referenced
this pull request
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
HCB PMO... it doesn't remember what login methods I use across devices, and I spend probably a combined hour each year just clicking "Sign in another way" when an email code gets sent to my inbox.
Describe your changes
HCB will infer the login method you'd like to use based on the last successful login attempt. It will automatically select the two methods you've previously used, so there's no need to click "Sign in another way" and feel bad for the tireless and pointless work done by
::LoginCodeService::Request.