Add initial applications table #12188

YodaLightsabr · 2025-11-23T02:35:16Z

Summary of the problem

Describe your changes

github-actions · 2025-11-23T03:15:49Z

app/views/event/applications/edit.html.erb

+  <p>Loading application...</p>
+<% end %>


Suggested change

<p>Loading application...</p>

<% end %>

<p>Loading application...</p>

<% end %>

github-actions · 2025-11-23T03:15:49Z

app/views/event/applications/new.html.erb

+
+<%= button_to "Start application", applications_path, method: :post, class: "btn" %>


Suggested change

<%= button_to "Start application", applications_path, method: :post, class: "btn" %>

<%= button_to "Start application", applications_path, method: :post, class: "btn" %>

github-actions · 2025-11-23T03:15:49Z

app/views/event/applications/steps/personal_info.html.erb

+    </div>
+
+    <%= form.submit "Next" %>
+  <% end %>
+<% end %>


Suggested change

</div>

<%= form.submit "Next" %>

<% end %>

<% end %>

</div>

<%= form.submit "Next" %>

<% end %>

<% end %>

github-actions · 2025-11-23T03:15:49Z

app/views/event/applications/steps/project_info.html.erb

+    </div>
+
+    <%= form.submit "Next" %>
+  <% end %>
+<% end %>


Suggested change

</div>

<%= form.submit "Next" %>

<% end %>

<% end %>

</div>

<%= form.submit "Next" %>

<% end %>

<% end %>

github-actions · 2025-11-23T18:44:01Z

app/controllers/event/applications_controller.rb

+    layout "apply"
+
+    def new


Suggested change

layout "apply"

def new

layout "apply"

def new

app/views/layouts/apply.html.erb

github-actions · 2025-11-23T18:44:02Z

app/views/static_pages/index.html.erb


+
 <% if current_user.card_grants.not_activated.size > 0 %>


Suggested change

<% if current_user.card_grants.not_activated.size > 0 %>

<% if current_user.card_grants.not_activated.size > 0 %>

github-actions · 2025-11-23T18:44:02Z

app/views/static_pages/index.html.erb

+
+
 <% if current_user.card_grants.activated.size > 0 %>


Suggested change

<% if current_user.card_grants.activated.size > 0 %>

<% if current_user.card_grants.activated.size > 0 %>

github-actions · 2025-11-23T23:28:56Z

app/views/event/applications/personal_info.html.erb

+<% end %>
+


Suggested change

<% end %>

<% end %>

…& continue

github-actions · 2025-11-25T20:27:39Z

app/views/event/applications/project_info.html.erb

+
+
+    <div class="max-w-lg card flex flex-col gap-3 card--sunken mb-7">


Suggested change

<div class="max-w-lg card flex flex-col gap-3 card--sunken mb-7">

<div class="max-w-lg card flex flex-col gap-3 card--sunken mb-7">

app/views/layouts/apply.html.erb

github-actions · 2025-11-25T20:38:49Z

app/javascript/controllers/autosave_controller.js

+export default class extends Controller {
+  static targets = ['indicator', 'form'];
+
+  connect () {
+    console.log("Connected!");
+  }
+}


Suggested change

export default class extends Controller {

static targets = ['indicator', 'form'];

connect () {

console.log("Connected!");

}

}

export default class extends Controller {

static targets = ['indicator', 'form']

connect() {

console.log('Connected!')

}

}

garyhtou · 2025-11-25T22:54:17Z

app/controllers/event/applications_controller.rb

+      @application = Event::Application.create!(user: current_user)
+      authorize @application


Suggested change

@application = Event::Application.create!(user: current_user)

authorize @application

authorize (@application = Event::Application.new(user: current_user))

@application.save!

garyhtou · 2025-11-25T22:55:34Z

config/routes.rb

+      get "personal_info"
+      get "project_info"


Suggested change

get "personal_info"

get "project_info"

member do

get "personal", to: "applications#personal_info"

get "project", to: "applications#project_info"

end

garyhtou · 2025-11-25T22:56:45Z

app/controllers/event/applications_controller.rb

+      @application.update!(application_params)
+
+      @return_to = url_from(params[:event_application][:return_to])
+
+      return redirect_to @return_to if @return_to.present?
+
+      redirect_back_or_to application_path(@application)


We need to pass these errors to the frontend

garyhtou · 2025-11-25T22:58:01Z

app/javascript/controllers/autosave_controller.js

@@ -0,0 +1,9 @@
+import { Controller } from '@hotwired/stimulus'
+
+export default class extends Controller {


Check out https://github.com/stimulus-use/stimulus-use/blob/main/docs/use-debounce.md

garyhtou · 2025-11-25T23:02:09Z

app/controllers/event/applications_controller.rb

+    private
+
+    def set_application
+      @application = Application.find(params[:application_id] || params[:id])


Suggested change

@application = Application.find(params[:application_id] || params[:id])

@application = Application.find(params[:id])

garyhtou · 2025-11-25T23:11:21Z

app/models/event/application.rb

+#  updated_at          :datetime         not null
+#  airtable_record_id  :string
+#  event_id            :bigint
+#  user_id             :bigint           not null


@polypixeldev and i talked about making this a one-to-many, but that's low priority and can be migrated in the future.

we'll keep it one to one for now

garyhtou · 2025-11-25T23:12:43Z

app/views/event/applications/_application_card.html.erb

+    <div class="p-4">
+      <div class="flex flex-row items-center justify-between">
+        <h3 class="heading h3 mb-2 mt-0">
+          <%= application.name || "Draft application" %>


Suggested change

<%= application.name || "Draft application" %>

<%= application.name.presence || "Draft application" %>

garyhtou · 2025-11-25T23:13:16Z

app/views/event/applications/_application_card.html.erb

+      </div>
+    </div>
+    <div class="bg-smoke bg-opacity-30 h-1">
+      <div class="bg-primary h-1" style="width: <%= application&.completion_percentage || 0 %>%"></div>


Suggested change

<div class="bg-primary h-1" style="width: <%= application&.completion_percentage || 0 %>%"></div>

<div class="bg-primary h-1" style="width: <%= application.completion_percentage || 0 %>%"></div>

garyhtou · 2025-11-25T23:18:28Z

app/views/layouts/apply.html.erb

+          </div>
+          <% if @application.present? %>
+            <div class="bg-smoke dark:bg-slate h-1">
+              <div class="bg-primary h-1" style="width: <%= @application&.completion_percentage || 0 %>%"></div>


Suggested change

<div class="bg-primary h-1" style="width: <%= @application&.completion_percentage || 0 %>%"></div>

<div class="bg-primary h-1" style="width: <%= @application.completion_percentage %>%"></div>

garyhtou · 2025-11-25T23:21:05Z

app/views/static_pages/index.html.erb

+<% if current_user.applications.any? %>
+  <div class="my-2 ml-0 py-2 px-4 flex flex-row items-end justify-between">
+    <h2 class="heading h2 line-height-4 m-0 p-0 border-none">Applications</h2>
+    <%= link_to applications_path, class: "flex items-center shrink-0 no-underline" do %>
+      View all applications
+      <%= inline_icon "view-forward" %>
+    <% end %>
+  </div>
+
+  <div class="grid grid--wide mb-12 pb-2 px-4">
+    <% current_user.applications.each do |application| %>
+      <%= render partial: "event/applications/application_card", locals: { application: } %>
+    <% end %>
+  </div>
+<% end %>


Only show applications that are not archived. Add an archived_at

github-actions · 2025-12-01T03:09:22Z

app/views/event/applications/personal_info.html.erb

+        </div>
+
+        <div class="field">


Suggested change

</div>

<div class="field">

</div>

<div class="field">

github-actions · 2025-12-01T03:35:42Z

app/views/event/applications/personal_info.html.erb

+        <hr class="col-span-2">
+
+        <div class="field mb-0">


Suggested change

<hr class="col-span-2">

<div class="field mb-0">

<hr class="col-span-2">

<div class="field mb-0">

## Summary of the problem  Currently, we send all our signees and cosigners to DocuSeal's website to sign the contract. This takes them outside of HCB's flow and prevents us from adding additional information, such as FAQs, when signing the contract. This is especially an issue for the upcoming new onboarding flow, which will be entirely within HCB (#12188). We're also relying entirely on DocuSeal's webhooks and fetching the contract from DocuSeal to keep track of contracts. This could be unreliable and also couples the code tightly to DocuSeal. ## Describe your changes  Creates `Contract::Party`, which belongs to a contract. There will be one party on HCB for each party on DocuSeal. A `show` action on the parties controller will be where both signees and cosigners can sign the HCB contract. Much of the party-specific logic in the Contract model and the DocuSeal webhook has been extracted into this new model. Using DocuSeal's support for embedding a contract form within our website using JavaScript, the contract form is side-by-side with a FAQ card with common questions that signees and parents often have when signing the contract. After signing, they will be directed to a completed page where a message will be displayed with next steps. `OneTimeJobs::BackfillContractParties` has also been added to backfill this new model. This should be run in production immediately after deployment to avoid errors when people try to sign existing contracts. Signing page: <img width="1043" height="862" alt="image" src="https://github.com/user-attachments/assets/9303f6f9-ff75-4390-b2d6-0e8831040efb" /> Completed page: <img width="881" height="311" alt="image" src="https://github.com/user-attachments/assets/033a2395-3790-4646-b2e4-211018f0a9d9" /> --------- Co-authored-by: Gary Tou <gary@garytou.com> Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

github-actions · 2026-01-10T06:04:17Z

app/assets/stylesheets/_dark.scss

    box-shadow: none;
-    background-color: rgba(map-get($palette, dark), 0.75);
+    background-color: rgba(map-get($palette, dark), 0.50);
  }


Suggested change

box-shadow: none;

background-color: rgba(map-get($palette, dark), 0.75);

background-color: rgba(map-get($palette, dark), 0.50);

}

box-shadow: none;

background-color: rgba(map-get($palette, dark), 0.5);

}

github-actions · 2026-01-10T06:04:18Z

app/assets/stylesheets/components/_cards.scss

    box-shadow: none;
-    background-color: rgba(map-get($palette, smoke), 0.75);
+    background-color: rgba(map-get($palette, smoke), 0.50);
  }


Suggested change

box-shadow: none;

background-color: rgba(map-get($palette, smoke), 0.75);

background-color: rgba(map-get($palette, smoke), 0.50);

}

box-shadow: none;

background-color: rgba(map-get($palette, smoke), 0.5);

}

polypixeldev added 7 commits November 7, 2025 02:54

Add initial applications table

38f289b

Remove non-null assertions and add draft state

e4710de

Rename Application to Event::Application

57e51a1

Rename columns on application table

c1588bc

Add under_review state

d201707

Add relation to event from event applications

7c5323e

Application form skeleton

6caf032

YodaLightsabr requested review from a team as code owners November 23, 2025 02:35

Merge branch 'main' into polypixeldev/new-applications

3bca183

github-actions bot reviewed Nov 23, 2025

View reviewed changes

YodaLightsabr added 3 commits November 23, 2025 18:40

Add applications to homepage

7234f15

Add apply layout

188898d

Improve application flow and small refactors

1e5bb81

github-actions bot reviewed Nov 23, 2025

View reviewed changes

YodaLightsabr and others added 4 commits November 23, 2025 12:45

Merge branch 'main' into polypixeldev/new-applications

9d0a921

Lint

fbc317f

Add end tag

ee5b082

Use layouts instead of turbo frames

95e01ff

github-actions bot reviewed Nov 23, 2025

View reviewed changes

YodaLightsabr added 2 commits November 24, 2025 19:45

Improve applications cards, create apps homepage, and build out save …

2062058

…& continue

Lint

033011c

Luke-Oldenburg changed the title ~~[WIP] Add initial applications table~~ Add initial applications table Nov 25, 2025

Luke-Oldenburg marked this pull request as draft November 25, 2025 00:46

UI improvements

266acd5

github-actions bot reviewed Nov 25, 2025

View reviewed changes

YodaLightsabr added 3 commits November 25, 2025 20:29

Lint

4cece94

Lint

d590756

Add autosave controller

1db7de5

github-actions bot reviewed Nov 25, 2025

View reviewed changes

Add layout divs to personal info page

b5b07c4

garyhtou reviewed Nov 25, 2025

View reviewed changes

YodaLightsabr and others added 5 commits November 25, 2025 23:32

Copy change

8154040

Merge branch 'main' into polypixeldev/new-applications

a096eb4

Update schema

92e9460

Replace apply form url

5d81131

Fix CSS on personal info page

d739911

github-actions bot reviewed Dec 1, 2025

View reviewed changes

polypixeldev added 2 commits December 1, 2025 03:29

Add parent email to personal info section

d650293

Improve personal info form styling

71b6ddf

github-actions bot reviewed Dec 1, 2025

View reviewed changes

polypixeldev added 2 commits December 8, 2025 22:05

Fix spacing in apply layout title

2146114

Fix formatting

b93a74c

polypixeldev mentioned this pull request Dec 10, 2025

Add contract signing within HCB #12377

Merged

YodaLightsabr and others added 4 commits January 9, 2026 17:16

Merge branch 'main' into polypixeldev/new-applications

8032834

Update DB versions

f5db550

Update card coloring

d451dc9

Update application flow and add review page

9445d78

github-actions bot reviewed Jan 10, 2026

View reviewed changes

YodaLightsabr and others added 5 commits January 10, 2026 08:26

Lint

7da6175

Conditional layout setting

08fd64a

URL front-end helper

9bf6108

Major refactors, additions, visual improvements, and upgrades

dfa8a53

Merge branch 'main' into polypixeldev/new-applications

7526d46

		<p>Loading application...</p>
		<% end %> No newline at end of file


		<%= button_to "Start application", applications_path, method: :post, class: "btn" %> No newline at end of file



	<% if current_user.card_grants.not_activated.size > 0 %>

	<% if current_user.card_grants.not_activated.size > 0 %>



	<% if current_user.card_grants.activated.size > 0 %>

	<% if current_user.card_grants.activated.size > 0 %>



		<div class="max-w-lg card flex flex-col gap-3 card--sunken mb-7">

		@application = Event::Application.create!(user: current_user)
		authorize @application

-      get "personal_info"
-      get "project_info"
+			member do
+        get "personal", to: "applications#personal_info"
+        get "project", to: "applications#project_info"
+      end

		@@ -0,0 +1,9 @@
		import { Controller } from '@hotwired/stimulus'

		export default class extends Controller {

	@application = Application.find(params[:application_id] \|\| params[:id])
	@application = Application.find(params[:id])

	<%= application.name \|\| "Draft application" %>
	<%= application.name.presence \|\| "Draft application" %>

	<div class="bg-primary h-1" style="width: <%= application&.completion_percentage \|\| 0 %>%"></div>
	<div class="bg-primary h-1" style="width: <%= application.completion_percentage \|\| 0 %>%"></div>

Add initial applications table #12188

Are you sure you want to change the base?

Add initial applications table #12188

Uh oh!

Conversation

YodaLightsabr commented Nov 23, 2025

Summary of the problem

Describe your changes

Uh oh!

github-actions bot Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees